Conversation
|
Spike test Stress test Authentication test Load test |
…adorsys/status-list-server into performance-test
IngridPuppet
left a comment
IngridPuppet
left a comment
There was a problem hiding this comment.
Great tool! I saw no requests failed so we're good I guess. While you're working on updating the logic given recent updates to the server, I have a few comments for now. Please check below.
IngridPuppet
left a comment
IngridPuppet
left a comment
There was a problem hiding this comment.
I reopened some conversations. Please could you check?
IngridPuppet
left a comment
IngridPuppet
left a comment
There was a problem hiding this comment.
A few comments before I run the Prometheus setup locally tomorrow.
There was a problem hiding this comment.
Hello @Ngha-Boris, I’ve gone through your implementation and left several comments.
Could you check them and address the necessary changes?
I also notice that you didn't add the pictures showing the resource consumptions during the tests. Could you mind adding them?
IngridPuppet
left a comment
IngridPuppet
left a comment
There was a problem hiding this comment.
I could check the Prometheus setup locally. Works like a charm. Just a few more comments though.
Hermann-Core
left a comment
Hermann-Core
left a comment
There was a problem hiding this comment.
The implementation looks solid to me, please review the few comments I left below.
4 participants
No description provided.