Summary
When plugin rendering fails in edit mode, django CMS renders a cms-rendering-exception block so editors can see that a placeholder could not be rendered. Older code built that block's heading by interpolating the exception message, placeholder/source strings, and the failing plugin's short description directly into an HTML string, then returned the placeholder output as safe markup.
If an editor could store HTML in data used by a plugin's get_short_description() (or in other values interpolated into the exception message), and that plugin later raised during edit-mode rendering, the payload was parsed as HTML in the staff user's browser. This is a stored XSS condition in the CMS editing context.
Impact
The vulnerable path is only reached when placeholder rendering catches a plugin rendering exception:
try:
placeholder_content = "".join(plugin_content)
except Exception as e:
context["exc_info"] = sys.exc_info()
placeholder_content = self.render_exception("rendering placeholder", context, placeholder, editable)render_exception() constructs a message from values that can include stored content:
value - the exception message.placeholder - the placeholder string representation.placeholder.source - the source object string representation, such as page content.instance.get_short_description() - plugin-provided summary text, often derived from plugin model fields.
In the vulnerable implementation, that message was embedded directly into an HTML heading. The final placeholder content was later returned through mark_safe, so Django template autoescaping did not protect the heading.
settings.DEBUG does not mitigate the issue: it only controls whether Django's traceback HTML is appended. The custom heading is rendered in edit mode regardless of DEBUG.
Patch
Escape the custom exception heading before returning it as safe placeholder markup. The current fixed code uses format_html, which escapes message before inserting it into the heading:
heading = format_html('<h2 class="cms-rendering-exception-title">{}</h2>', message)The traceback HTML from ExceptionReporter.get_traceback_html() should remain separate from django CMS's custom heading; Django's traceback escaping does not protect additional HTML assembled by django CMS.
Workarounds
Until patched, reduce exposure by ensuring only fully trusted staff can edit plugins whose stored fields are included in get_short_description(), and fix or disable plugins that can be made to raise during edit-mode rendering. This is only a partial mitigation because the escaping bug is in the shared exception-rendering path.
References
cms/plugin_rendering.py - ContentRenderer.render_placeholdercms/plugin_rendering.py - ContentRenderer.render_exception- Fixed code:
heading = format_html('<h2 class="cms-rendering-exception-title">{}</h2>', message)
- Regression tests:
cms.tests.test_plugin_renderers.TestExceptionCatchers.test_exception_in_plugin_render_escapes_user_content_in_edit_mode,
cms.tests.test_plugin_renderers.TestLegacyRendererExceptionCatcher.test_exception_in_plugin_render_escapes_user_content_in_edit_mode
References
meifukun Reporter
Summary
When plugin rendering fails in edit mode, django CMS renders a
cms-rendering-exceptionblock so editors can see that a placeholder could not be rendered. Older code built that block's heading by interpolating the exception message, placeholder/source strings, and the failing plugin's short description directly into an HTML string, then returned the placeholder output as safe markup.If an editor could store HTML in data used by a plugin's
get_short_description()(or in other values interpolated into the exception message), and that plugin later raised during edit-mode rendering, the payload was parsed as HTML in the staff user's browser. This is a stored XSS condition in the CMS editing context.Impact
The vulnerable path is only reached when placeholder rendering catches a plugin rendering exception:
render_exception()constructs amessagefrom values that can include stored content:value- the exception message.placeholder- the placeholder string representation.placeholder.source- the source object string representation, such as page content.instance.get_short_description()- plugin-provided summary text, often derived from plugin model fields.In the vulnerable implementation, that message was embedded directly into an HTML heading. The final placeholder content was later returned through
mark_safe, so Django template autoescaping did not protect the heading.settings.DEBUGdoes not mitigate the issue: it only controls whether Django's traceback HTML is appended. The custom heading is rendered in edit mode regardless ofDEBUG.Patch
Escape the custom exception heading before returning it as safe placeholder markup. The current fixed code uses
format_html, which escapesmessagebefore inserting it into the heading:The traceback HTML from
ExceptionReporter.get_traceback_html()should remain separate from django CMS's custom heading; Django's traceback escaping does not protect additional HTML assembled by django CMS.Workarounds
Until patched, reduce exposure by ensuring only fully trusted staff can edit plugins whose stored fields are included in
get_short_description(), and fix or disable plugins that can be made to raise during edit-mode rendering. This is only a partial mitigation because the escaping bug is in the shared exception-rendering path.References
cms/plugin_rendering.py-ContentRenderer.render_placeholdercms/plugin_rendering.py-ContentRenderer.render_exceptionheading = format_html('<h2 class="cms-rendering-exception-title">{}</h2>', message)cms.tests.test_plugin_renderers.TestExceptionCatchers.test_exception_in_plugin_render_escapes_user_content_in_edit_mode,cms.tests.test_plugin_renderers.TestLegacyRendererExceptionCatcher.test_exception_in_plugin_render_escapes_user_content_in_edit_modeReferences