Summary
The POST /api/v1/repos/{owner}/{repo}/merge-upstream endpoint continues to synchronize commits from a parent repository after the parent repository has been changed from public to private.
A fork created while the parent repository was public can still receive commits made after the parent repository becomes private. As a result, content added during the private period becomes available through the fork repository after synchronization.
Details
Gitea provides the merge-upstream API to synchronize a fork with its parent repository.
A typical workflow is:
- A repository is public.
- Another user creates a fork.
- The fork owner uses
merge-upstream to receive updates from the parent repository.
However, if the parent repository is later changed from public to private, the synchronization endpoint continues to import new commits from the parent repository into the fork.
In testing on Gitea 1.26.2, a fork owner who can no longer directly access the parent repository is still able to synchronize newly created commits from the parent repository into the fork by calling merge-upstream.
As a result, commits created after the visibility change can be propagated into the fork through the normal fork synchronization workflow.
PoC
Proof-of-Concept Code
https://anonymous.4open.science/r/Gitea_PoC-EC93/4_poc_merge_upstream
PoC Details
- User
alice creates a public repository alice/P.
- User
bob forks the repository, creating bob/P.
alice changes alice/P from public to private.- Verify that
bob can no longer directly access the parent repository:
GET /api/v1/repos/alice/P
Response:
GET /api/v1/repos/alice/P/contents/README.md
Response:
- While the repository is private,
alice commits a new file:
secret.txt
- Verify that
bob cannot directly access the new file from the parent repository:
GET /api/v1/repos/alice/P/contents/secret.txt
Response:
bob synchronizes the fork:
POST /api/v1/repos/bob/P/merge-upstream
Response:
- The newly added file is now available through the fork repository:
GET /api/v1/repos/bob/P/contents/secret.txt
Response:
The attached PoC reproduces the behavior end-to-end.
As a control test, attempting to access the private-period commit directly through the fork's Git API before synchronization fails:
GET /api/v1/repos/bob/P/git/commits/<private-period-commit-sha>
Response:
This indicates that the commit becomes available in the fork only after the merge-upstream operation synchronizes it from the parent repository.
Impact
A fork created while a repository is public can continue receiving updates from the parent repository after the parent repository is changed to private.
Consequently, content committed after the visibility change may become available through fork synchronization even when the fork owner can no longer directly access the parent repository.
The impact is limited to content that is synchronized from the parent repository into the affected fork. The issue does not allow modification of the parent repository or access to repositories that were never forked.
References
ybsun0215 Reporter
Summary
The
POST /api/v1/repos/{owner}/{repo}/merge-upstreamendpoint continues to synchronize commits from a parent repository after the parent repository has been changed from public to private.A fork created while the parent repository was public can still receive commits made after the parent repository becomes private. As a result, content added during the private period becomes available through the fork repository after synchronization.
Details
Gitea provides the
merge-upstreamAPI to synchronize a fork with its parent repository.A typical workflow is:
merge-upstreamto receive updates from the parent repository.However, if the parent repository is later changed from public to private, the synchronization endpoint continues to import new commits from the parent repository into the fork.
In testing on Gitea 1.26.2, a fork owner who can no longer directly access the parent repository is still able to synchronize newly created commits from the parent repository into the fork by calling
merge-upstream.As a result, commits created after the visibility change can be propagated into the fork through the normal fork synchronization workflow.
PoC
Proof-of-Concept Code
https://anonymous.4open.science/r/Gitea_PoC-EC93/4_poc_merge_upstream
PoC Details
alicecreates a public repositoryalice/P.bobforks the repository, creatingbob/P.alicechangesalice/Pfrom public to private.bobcan no longer directly access the parent repository:Response:
404 Not FoundResponse:
404 Not Foundalicecommits a new file:bobcannot directly access the new file from the parent repository:Response:
404 Not Foundbobsynchronizes the fork:Response:
200 OKResponse:
200 OKThe attached PoC reproduces the behavior end-to-end.
As a control test, attempting to access the private-period commit directly through the fork's Git API before synchronization fails:
Response:
404 Not FoundThis indicates that the commit becomes available in the fork only after the
merge-upstreamoperation synchronizes it from the parent repository.Impact
A fork created while a repository is public can continue receiving updates from the parent repository after the parent repository is changed to private.
Consequently, content committed after the visibility change may become available through fork synchronization even when the fork owner can no longer directly access the parent repository.
The impact is limited to content that is synchronized from the parent repository into the affected fork. The issue does not allow modification of the parent repository or access to repositories that were never forked.
References