fix(memory): distinguish incomplete reads from missing records

[affaan-m]

Direct memory reads currently discard scan-completeness information. If traversal is truncated or a document cannot be parsed/read, an ID lookup can report a unique result or a missing record from only part of the authorized vault.

Fail these reads explicitly with ECC_MEMORY_INCOMPLETE, exposed through local MCP as MEMORY_READ_INCOMPLETE, without returning partial content or storage details. Complete reads, historical inspection, harness routing and user-scope denial are preserved. The generic read error also accounts for invalid/storage failures. Updated guidance explains completeness, current-state checks, supersession and the distinction between context and authority.

Validation on fresh main c4904e3f:

• 10 focused actual-core/direct-MCP regressions passed, including traversal truncation, malformed documents, injected file I/O failure and scope denial.
• All 35 existing vault-core tests passed.
• Installed ESLint and whitespace checks passed.
• Independent code and security reviews approved the exact six-file patch.

The new error code is intentional. A malformed document elsewhere in an authorized scan now requires vault repair before a complete direct lookup can succeed; search retains its existing partial-scan diagnostics. No dependency, schema, authentication backend or network-service change. Hosted CI remains separate from these local checks.

[ecc-tools]

ECC Tools / Security Evidence

Commit: 0655018179fa31818abe9c248e568d7e8f074854

Security evidence gate passed (success)

No security-sensitive scanner-evidence gap detected.

Mode: enforce

Scanned 6 changed file(s). No missing scanner-evidence signal was detected.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

[ecc-tools]

ECC Tools / PR Risk Taxonomy

Commit: 0655018179fa31818abe9c248e568d7e8f074854

PR taxonomy review recommended (neutral)

Detected 6 PR taxonomy bucket(s): Harness Drift, Install Manifest Integrity, CI/CD Recommendation, Reference Set Validation, Skill Quality, Agent Config Review.

Scanned 6 changed file(s).

Roadmap taxonomy buckets:

Harness Drift

Harness-facing changes can drift across Claude Code, Codex, OpenCode, and shared adapter surfaces.

Signals:

• 1 harness-facing path(s) changed

Paths:

• skills/unified-memory/SKILL.md

Install Manifest Integrity

Install manifests, plugin metadata, and shipped skills should stay synchronized with user-facing setup guidance.

Signals:

• 1 install or manifest path(s) changed

Paths:

• skills/unified-memory/SKILL.md

CI/CD Recommendation

CI, dependency, coverage, and contract signals should be routed into follow-up checks or verification work.

Signals:

• 2 CI or workflow path(s) changed

Paths:

• tests/lib/memory-read-completeness.test.js
• tests/lib/memory-vault.test.js

Reference Set Validation

AI, analyzer, skill, agent, command, and harness guidance changes should be compared against a maintained eval, golden trace, benchmark, or reference set.

Signals:

• AI or harness analysis changes may ship without reference-set validation
• 1 reference-sensitive path(s) changed

Paths:

• skills/unified-memory/SKILL.md

Skill Quality

Skill, agent, command, and rule guidance should carry examples, triggers, validation, or reference evidence.

Signals:

• Skill or agent guidance may ship without quality evidence
• 1 skill-quality path(s) changed

Paths:

• skills/unified-memory/SKILL.md

Agent Config Review

Agent, command, skill, MCP, and local instruction changes should be reviewed as executable agent configuration.

Signals:

• 1 agent-config path(s) changed

Paths:

• skills/unified-memory/SKILL.md

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

[ecc-tools]

ECC Tools / Reference Set Readiness

Commit: 0655018179fa31818abe9c248e568d7e8f074854

Reference set readiness gaps detected (neutral)

Reference evidence present for 0/7 areas (0%) across 6 changed file(s).

This check is based on files changed in this PR. Repository-level readiness is still reported by /ecc-tools analyze comments and generated manifests.

Area	Status	Evidence / Next Step
Deep analyzer corpus	Missing	Add analyzer fixture, golden, benchmark, or reference-set files that can catch analyzer regressions.
RAG/evaluator comparison	Missing	Add retrieval or evaluator reference-set comparison fixtures with expected ranking behavior.
PR salvage/review corpus	Missing	Add stale-PR, review-thread, reopen-flow, or salvage reference cases for queue cleanup automation.
Discussion triage corpus	Missing	Add public discussion triage fixtures, golden cases, or reference sets for informational, answered, and no-response classifications.
Harness compatibility	Missing	Add cross-harness, adapter-compliance, or harness-audit evidence for Claude, Codex, OpenCode, Zed, dmux, and agent surfaces.
Security evidence	Missing	Attach security evidence such as SBOMs, SARIF, audit reports, or AgentShield evidence packs.
CI failure-mode evidence	Missing	Add captured CI failure logs, dry-run fixtures, or troubleshooting docs for common workflow failure modes.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

[ecc-tools]

ECC Tools / Hosted Promotion Readiness

Commit: 0655018179fa31818abe9c248e568d7e8f074854

Hosted promotion readiness passed (success)

No hosted promotion evidence gaps detected across 6 changed file(s); 0 corpus scenarios had matching evidence.

This check compares PR file changes against the evaluator/RAG promotion corpus in src/analyzers/fixtures/evaluator-rag-corpus.ts.
Hosted output scoring inspected 0 completed cached hosted job results.

No evaluator corpus scenarios matched this PR.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}