Skip to content

Add agent-knowledge as git submodule#7

Merged
avifenesh merged 1 commit intomainfrom
feat/agent-knowledge-submodule
Mar 5, 2026
Merged

Add agent-knowledge as git submodule#7
avifenesh merged 1 commit intomainfrom
feat/agent-knowledge-submodule

Conversation

@avifenesh
Copy link
Copy Markdown
Contributor

Summary

  • Adds agent-knowledge as a git submodule pointing to agent-sh/agent-knowledge
  • Centralizes the shared knowledge base across all plugin repos
  • Single source of truth - update once, pull everywhere

Test plan

  • Verify git submodule update --init works after clone
  • Confirm knowledge files are accessible at agent-knowledge/

Centralizes knowledge base in agent-sh/agent-knowledge repo,
shared across all plugin repos via submodule.
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the agent-knowledge repository as a Git submodule. This strategic change aims to centralize and standardize the shared knowledge base across all related plugin repositories, ensuring a consistent and easily maintainable source of truth for critical information.

Highlights

  • Git Submodule Integration: Integrated agent-knowledge as a Git submodule, linking to agent-sh/agent-knowledge.
  • Knowledge Base Centralization: Centralized the shared knowledge base to be used across all plugin repositories.
  • Single Source of Truth: Established a single source of truth for the knowledge base, allowing updates in one place to propagate everywhere.
Changelog
  • .gitmodules
    • Added configuration for the new agent-knowledge submodule.
  • agent-knowledge
    • Added the agent-knowledge submodule, pointing to its initial commit.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the agent-knowledge repository as a git submodule to centralize a shared knowledge base. The implementation is straightforward. I've suggested one improvement in the .gitmodules configuration to use a relative URL for the submodule. This will improve portability and automatically use the same protocol (HTTPS or SSH) that the developer used for the main repository, which enhances the developer experience.

@@ -0,0 +1,3 @@
[submodule "agent-knowledge"]
path = agent-knowledge
url = https://github.com/agent-sh/agent-knowledge.git
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better portability and to respect the developer's choice of protocol (HTTPS vs SSH), it's recommended to use a relative URL for the submodule. A relative URL is resolved based on the main repository's remote URL, and it will use the same protocol that was used to clone the main repository. This makes it easier if the repository group is ever forked or moved to a different host.

	url = ../agent-knowledge.git

@avifenesh avifenesh merged commit eedd63d into main Mar 5, 2026
@avifenesh avifenesh deleted the feat/agent-knowledge-submodule branch March 5, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant