Surface Compound decimals-guard failure via errored flag (#36) - #38
Merged
Conversation
PR #35 tightened three of the four position-critical multicalls but left the base-token decimals guard at `return null` — the aggregator then reported clean coverage with a curated-registry market silently missing. Throw instead so Promise.allSettled classifies it as errored. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decimals()guard atreturn null. A transient failure on that read (with a nonzero base balance) silently dropped the market whilecoverage.compound.erroredstayed false — the aggregator reported clean coverage with a curated-registry market silently missing.Promise.allSettledwrapper ingetCompoundPositionsclassifies the market as errored and surfaces it viaerroredMarkets.test/session-regression.test.tsnow assertsresult.errored === trueand thaterroredMarketsnames the failing market, rather than just checking the old silent-skip behavior.Test plan
npx tsc --noEmitnpx vitest run— 395/395 pass🤖 Generated with Claude Code