refactor(types): extract chains + devices type clusters - #839
Draft
graciangabriel8 wants to merge 3 commits into
Draft
refactor(types): extract chains + devices type clusters#839graciangabriel8 wants to merge 3 commits into
graciangabriel8 wants to merge 3 commits into
Conversation
Part of #717. Cuts the chains cluster (SupportedChain/RpcProvider/ chain-id tables, 11 exports) and devices cluster (Ledger pairing entries, 6 exports) byte-identically out of src/types/index.ts into src/types/chains.ts and src/types/devices.ts; index.ts re-exports both via export * so all 158 existing import specifiers stay unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…oes not bind them locally
…ation) EDITORIAL DEVIATION from byte-mechanical extraction, per reviewer advice on PR #839: the one-line comment /** Shape of ~/.vaultpilot-mcp/config.json. */ had no blank-line separation from PairedSolanaEntry in the original file, so the mechanical block-cut carried it into devices.ts, where it read as (and was mistaken for) a file header despite actually describing UserConfig ~380 lines away in the original source. Deleting it rather than relocating it, per the reviewer's judgment that it's worse in devices.ts than left in situ.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cuts the
chainscluster (SupportedChain,RpcProvider, chain-id tables, 11 exports) and thedevicescluster (Ledger pairing entries, 6 exports) byte-identically out ofsrc/types/index.tsintosrc/types/chains.tsandsrc/types/devices.ts.index.tsre-exports both viaexport *so all 158 existing import specifiers stay byte-identical.Note: the block immediately preceding
PairedSolanaEntryin the original file carries a stray one-line comment (/** Shape of ~/.vaultpilot-mcp/config.json. */) that actually describesUserConfig, defined ~380 lines later — a pre-existing source quirk, not something this mechanical extraction alters. It rides along intodevices.tssince it has no blank-line separation fromPairedSolanaEntry.Part of #717
Note:
export * from "./x.js"re-exports but does not locally bind names, so index.ts also carriesimport type { ... } from "./x.js"for every moved name its own remaining declarations still reference by bare identifier — scope-plumbing that vanishes once the last domain leaves the file.Editorial deviation (per reviewer advice): deleted the stray
/** Shape of ~/.vaultpilot-mcp/config.json. */one-liner noted above rather than leaving it riding into devices.ts — it read there as a misleading file header. Everything else in this PR remains byte-mechanical.