refactor(signing): extract render/tron.ts - #846
Draft
graciangabriel8 wants to merge 2 commits into
Draft
Conversation
Cuts renderTronVerificationBlock, tronSwissKnifeUrl, and
renderTronAgentTaskBlock into render/tron.ts. Imports formatArgs and
truncateHex from ./format.js (PR1) — never back through the
render-verification.ts barrel, so no import cycle.
Range note: the plan flagged EXPLORER_TX_URL as a second Tron
dependency on PR1's modules, alongside truncateHex. Re-checking the
actual file, EXPLORER_TX_URL only appears inside a Tron code comment
("...same explorer URL via EXPLORER_TX_URL.tron.") — there's no
runtime reference, so tron.ts does not import it. truncateHex is the
only real cross-module dependency.
render-verification.ts re-exports the new module with `export *` (no
collisions) and drops the now-dead UnsignedTronTx import; formatArgs
and truncateHex stay imported there too since EVM's
renderVerificationBlock (not yet moved) still calls both directly.
Part of #718
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure-move PR 3/7 (stacked on #844), splitting Tron render logic out of render-verification.ts into
render/tron.ts: renderTronVerificationBlock, tronSwissKnifeUrl, renderTronAgentTaskBlock. Imports formatArgs and truncateHex from PR1's format.ts — never back through the render-verification.ts barrel.Range deviation from the plan: the plan named
EXPLORER_TX_URLas a second Tron dependency on PR1's modules alongsidetruncateHex. Re-derived from the actual file:EXPLORER_TX_URLonly appears inside a Tron code comment, with no runtime reference, so tron.ts imports onlytruncateHex(plusformatArgs, needed but not named in the plan's PR1 list — see #841).render-verification.ts re-exports the new module via
export *(no collisions) and drops the now-unusedUnsignedTronTximport.Part of #718
CI note: this stacked PR runs only
clauntil it is retargeted to main after its base merges — full CI fires at that point; reviewed by static trace in the meantime.