fix(actions): resolve capture core from action checkout - #159
Open
noah-ing wants to merge 1 commit into
Open
Conversation
Signed-off-by: Noah Ing <98993329+noah-ing@users.noreply.github.com>
|
🟡 Contributor Check: MEDIUM
Automated check by AgenTrust Contributor Check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resolve the bundled
agentrust-capture-corepackage from the composite action checkout for the Cursor, Copilot, Gemini CLI, and Windsurf actions, and add a regression test to the validation workflow.Why
For a remote action such as
uses: agentrust-io/integrations/cursor@<ref>,GITHUB_WORKSPACEpoints to the caller's repository, not the checkout containing the action. The current install command therefore looks forpackages/agentrust-capture-corein the consumer repository and fails unless that unrelated path happens to exist.${{ github.action_path }}identifies the checked-out action directory. Resolving../packages/agentrust-capture-corefrom there keeps the package and action on the same referenced revision and avoids crossing into caller-controlled workspace content.The new regression creates separate action and consumer checkout trees, places a decoy package path in the consumer tree, and verifies all four actions resolve only the bundled package from the action checkout.
Test plan
python -m pytest tests -q— 28 passedpython scripts/validate_integrations.py— 35 integrations, 0 failurespython scripts/validate_compatibility.py— 0 failuresnox— all 14 isolated sessions passeddetect-secrets1.5.0 on changed files — 0 findingsgit diff --checkandgit fsck --full— passedDCO
The commit is signed off under the Developer Certificate of Origin.