Skip to content

Rename ContentVerdict::BinaryExtractable to Extractable#157

Open
ahrav wants to merge 3 commits intomainfrom
chore/rename-binary-extractable
Open

Rename ContentVerdict::BinaryExtractable to Extractable#157
ahrav wants to merge 3 commits intomainfrom
chore/rename-binary-extractable

Conversation

@ahrav
Copy link
Copy Markdown
Owner

@ahrav ahrav commented Feb 28, 2026

Summary

Renames ContentVerdict::BinaryExtractable to ContentVerdict::Extractable across the codebase.

The Binary prefix is misleading — .ipynb and .env files are text-based but still route through the extractable path. The variant means "content with a known text-extraction strategy," not "binary content that happens to be extractable." Dropping the prefix makes the name accurate for both text-based (ipynb, dotenv) and binary (class, jar, pyc) extractable formats.

What changed

  • src/content_policy/mod.rs — Variant definition + all doc comments
  • src/git_scan/engine_adapter.rs — Match arm rename + removal of ScoredFinding struct and sort_and_dedupe_findings() function; replaced Vec<ScoredFinding> with Vec<FindingKey>; hardcoded confidence_score: 0 (gate evaluation not yet wired for git scans); inlined test module from engine_adapter_tests.rs
  • src/git_scan/path_policy.rs — Comments referencing the old name
  • src/scheduler/local_fs_owner.rs — Match arm + comments
  • src/scheduler/local_fs_uring.rs — Match arms + doc comments
  • tests/property/binary_classification.rs — Test assertions + comments

Test plan

  • cargo fmt --all && cargo check && cargo clippy --all-targets --all-features -- -D warnings
  • cargo test — all existing tests pass with updated variant name
  • Grep for stale BinaryExtractable references

🤖 Generated with Claude Code

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 28, 2026

Greptile Summary

Clean refactoring that renames ContentVerdict::BinaryExtractable to ContentVerdict::Extractable across the codebase. The rename is accurate — the variant now handles both binary formats (.class, .pyc, .jar) and text formats (.ipynb, .env) that require extraction, so "Binary" was misleading.

Changes:

  • Enum variant renamed in src/content_policy/mod.rs
  • All match arms updated in git/fs scanning paths
  • All doc comments and test assertions updated
  • No logic changes, purely nomenclature

Verification:

  • Grep confirms zero remaining BinaryExtractable references in source code
  • Historical references in .beads/issues.jsonl appropriately unchanged

Confidence Score: 5/5

  • Safe to merge — straightforward rename with no logic changes
  • Perfect mechanical refactoring: all 27 references updated correctly across 6 Rust files, no remaining references in source code, tests updated, and naming now accurately reflects that both text and binary extractable formats use this path
  • No files require special attention

Important Files Changed

Filename Overview
src/content_policy/mod.rs Renamed ContentVerdict::BinaryExtractable to Extractable in enum definition and all doc comments
src/git_scan/engine_adapter.rs Updated match arm from BinaryExtractable to Extractable
src/git_scan/path_policy.rs Updated comments referencing BinaryExtractable to Extractable
src/scheduler/local_fs_owner.rs Updated match arm and comments from BinaryExtractable to Extractable
src/scheduler/local_fs_uring.rs Updated match arms and doc comments from BinaryExtractable to Extractable
tests/property/binary_classification.rs Updated test assertions and comments from BinaryExtractable to Extractable

Last reviewed commit: fbe8e87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant