Rename ContentVerdict::BinaryExtractable to Extractable#157
Open
Rename ContentVerdict::BinaryExtractable to Extractable#157
Conversation
Contributor
Greptile SummaryClean refactoring that renames Changes:
Verification:
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: fbe8e87 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames
ContentVerdict::BinaryExtractabletoContentVerdict::Extractableacross the codebase.The
Binaryprefix is misleading —.ipynband.envfiles are text-based but still route through the extractable path. The variant means "content with a known text-extraction strategy," not "binary content that happens to be extractable." Dropping the prefix makes the name accurate for both text-based (ipynb, dotenv) and binary (class, jar, pyc) extractable formats.What changed
src/content_policy/mod.rs— Variant definition + all doc commentssrc/git_scan/engine_adapter.rs— Match arm rename + removal ofScoredFindingstruct andsort_and_dedupe_findings()function; replacedVec<ScoredFinding>withVec<FindingKey>; hardcodedconfidence_score: 0(gate evaluation not yet wired for git scans); inlined test module fromengine_adapter_tests.rssrc/git_scan/path_policy.rs— Comments referencing the old namesrc/scheduler/local_fs_owner.rs— Match arm + commentssrc/scheduler/local_fs_uring.rs— Match arms + doc commentstests/property/binary_classification.rs— Test assertions + commentsTest plan
cargo fmt --all && cargo check && cargo clippy --all-targets --all-features -- -D warningscargo test— all existing tests pass with updated variant nameBinaryExtractablereferences🤖 Generated with Claude Code