refactor: extract client and alarm handling to dedicated packages(3/4)#141
Draft
ravisastryk wants to merge 3 commits intoahrtr:mainfrom
Draft
refactor: extract client and alarm handling to dedicated packages(3/4)#141ravisastryk wants to merge 3 commits intoahrtr:mainfrom
ravisastryk wants to merge 3 commits intoahrtr:mainfrom
Conversation
- Move version.go → pkg/version/version.go (public API) - Move config.go → internal/config/config.go Part of codebase reorganization (Issue ahrtr#137). No functional changes. PR 1 of 4 in the stacked refactoring series.
- Move rule evaluation logic to internal/eval - Move endpoint resolution and filtering to internal/endpoint - Relocate associated tests to new package locations Part of codebase reorganization (Issue ahrtr#137). No functional changes. PR 2 of 4 in the stacked refactoring series.
- Move disalarm.go → internal/alarm/disalarm.go - Create internal/client/client.go for etcd client wrapper Part of codebase reorganization (Issue ahrtr#137). No functional changes. PR 3 of 4 in the stacked refactoring series.
ravisastryk
force-pushed
the
refactor/pr3-client-alarm
branch
from
621c734 to
7446bfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: extract client and alarm handling to dedicated packages(3/4)
Part of codebase reorganization (Issue #137).
No functional changes.
PR 3 of 4 in the stacked refactoring series.