Test/pt overhead draft#1816
Draft
fengjica wants to merge 4 commits into
Draft
Conversation
- progressCompletionQueue: add lock_acquired and use_try_lock params - PT uses try_lock (less likely to blocks data thread) - Data thread uses blocking lock in postXfer/checkXfer/getNotifs - EAGAIN retry loops drain CQ under same lock (lock_acquired=true) - Remove if (!progress_thread_enabled_) guards so data thread always progresses completions
Use an RAII guard to set data_thread_active_ flag during postXfer. The progress thread skips polling when this flag is set, since the data thread handles its own CQ progress. Eliminates ep_mutex_ contention during active submission bursts.
|
👋 Hi fengjica! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Describe what this PR is doing.
Why?
Justification for the PR. If there is an existing issue/bug, please reference it. For
bug fixes, the 'Why?' and 'What?' can be merged into a single item.
How?
It is optional, but for complex PRs, please provide information about the design,
architecture, approach, etc.