ci: switch back to avoid build C++ tests in release builds#1817
ci: switch back to avoid build C++ tests in release builds#1817nv-nmailhot wants to merge 1 commit into
Conversation
Restore the buildtype guard on the build_tests gate (reverts the #1803 change). The unit tests carry latent -Werror debt that only surfaces in release builds (-O3 -DNDEBUG, where assert() is a no-op so checked-only vars go unused and assert(0) defaults fall off non-void functions), and they aren't needed for the release wheel. Build them only in non-release buildtypes — the alternative to fixing each test's -Werror violations. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Meson build gate for including the ChangesTest Build Gate
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/build |
Restore the buildtype guard on the build_tests gate (reverts the #1803 change). The unit tests carry latent -Werror debt that only surfaces in release builds (-O3 -DNDEBUG, where assert() is a no-op so checked-only vars go unused and assert(0) defaults fall off non-void functions), and they aren't needed for the release wheel. Build them only in non-release buildtypes — the alternative to fixing each test's -Werror violations.
What?
Describe what this PR is doing.
Why?
Justification for the PR. If there is an existing issue/bug, please reference it. For
bug fixes, the 'Why?' and 'What?' can be merged into a single item.
How?
It is optional, but for complex PRs, please provide information about the design,
architecture, approach, etc.
Summary by CodeRabbit