Skip to content

telemetry: don't unlink the producer's file when attaching fails #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EylonKrause wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −3
Open

telemetry: don't unlink the producer's file when attaching fails #1826

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2779a7
telemetry: don't unlink the producer's file when attaching fails
EylonKrause Jun 24, 2026
114d9b1
Merge branch 'main' into fix/telemetry-reader-unlink
iyastreb Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/utils/common/cyclic_buffer.tpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
* SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
* SPDX-License-Identifier: Apache-2.0
*
* Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -208,7 +208,6 @@ sharedRingBuffer<T>::openCyclicBuffer(const std::string &name, int version) {
void *header_ptr =
mmap(nullptr, sizeof(bufferHeader), PROT_READ | PROT_WRITE, MAP_SHARED, *file_fd, 0);
if (header_ptr == MAP_FAILED) {
unlink(name.c_str());
NIXL_ERROR << "Failed to map header memory: " << name
<< " with error: " << strerror(errno);
throw std::runtime_error("Failed to map header memory");
Expand All @@ -220,7 +219,6 @@ sharedRingBuffer<T>::openCyclicBuffer(const std::string &name, int version) {
int current_version = temp_header->version.load(std::memory_order_acquire);
if (current_version != version) {
munmap(temp_header, sizeof(bufferHeader));
unlink(name.c_str());
NIXL_ERROR << "Version mismatch: expected " + std::to_string(version) + ", got " +
std::to_string(current_version);
throw std::runtime_error("Version mismatch: expected " + std::to_string(version) +
Expand Down
Loading