feat: file truncation and empty PDF warnings for user testing #14
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -84,6 +84,8 @@ const t = { | |||||||
| attach: "Attach file", | ||||||||
| parsing: "Reading files...", | ||||||||
| unsupported: "Supported: PDF, DOCX, Excel, and text files", | ||||||||
| truncated: (name: string) => `"${name}" is too long - only the first ~20 pages were included`, | ||||||||
| empty: (name: string) => `"${name}" appears to be scanned/empty - no text could be extracted`, | ||||||||
| settings: "Settings", | ||||||||
| signOut: "Sign Out", | ||||||||
| tooltips: { | ||||||||
|
|
@@ -118,6 +120,8 @@ const t = { | |||||||
| attach: "파일 첨부", | ||||||||
| parsing: "파일 읽는 중...", | ||||||||
| unsupported: "지원 형식: PDF, DOCX, Excel, 텍스트 파일", | ||||||||
| truncated: (name: string) => `"${name}" 파일이 너무 길어 앞부분만 포함되었습니다`, | ||||||||
| empty: (name: string) => `"${name}" 파일에서 텍스트를 추출할 수 없습니다 (스캔 문서일 수 있음)`, | ||||||||
| settings: "설정", | ||||||||
| signOut: "로그아웃", | ||||||||
| tooltips: { | ||||||||
|
|
@@ -315,19 +319,27 @@ export default function Home() { | |||||||
| // Auto-dismiss file error | ||||||||
| useEffect(() => { | ||||||||
| if (!fileError) return | ||||||||
| const timer = setTimeout(() => setFileError(null), 5000) | ||||||||
| return () => clearTimeout(timer) | ||||||||
| }, [fileError]) | ||||||||
|
|
||||||||
| const buildPromptWithFiles = async (): Promise<{ text: string | null; fileWarnings: string[] }> => { | ||||||||
| let messageText = prompt.trim() | ||||||||
| const fileWarnings: string[] = [] | ||||||||
|
|
||||||||
| if (files.length > 0) { | ||||||||
| const results = await Promise.allSettled( | ||||||||
| files.map(async (af) => { | ||||||||
| const parsed = await parseFile(af.file) | ||||||||
|
Comment on lines
+328
to
+333
There was a problem hiding this comment.
|
||||||||
| if (parsed.warning === "empty") { | ||||||||
| fileWarnings.push(t[locale].empty(af.file.name)) | ||||||||
| return null | ||||||||
| } | ||||||||
| if (parsed.warning === "truncated") { | ||||||||
| fileWarnings.push(t[locale].truncated(af.file.name)) | ||||||||
| } | ||||||||
| if (parsed.text && !parsed.text.startsWith("[Unsupported")) { | ||||||||
| return `--- File: ${af.file.name} ---\n${parsed.text}` | ||||||||
| } | ||||||||
| return null | ||||||||
| }) | ||||||||
|
|
@@ -351,15 +363,15 @@ export default function Home() { | |||||||
| } | ||||||||
| } | ||||||||
|
|
||||||||
| return { text: messageText || null, fileWarnings } | ||||||||
| } | ||||||||
|
|
||||||||
| const handleSubmit = async () => { | ||||||||
| if (isParsing || (!prompt.trim() && files.length === 0)) return | ||||||||
|
|
||||||||
| setIsParsing(true) | ||||||||
| try { | ||||||||
| const { text: messageText, fileWarnings } = await buildPromptWithFiles() | ||||||||
| if (!messageText) return | ||||||||
|
|
||||||||
| if (shouldShowLoginGate(!!session?.user)) { | ||||||||
|
|
@@ -382,6 +394,9 @@ export default function Home() { | |||||||
| locale, | ||||||||
| } | ||||||||
| sessionStorage.setItem("quorum_config", JSON.stringify(config)) | ||||||||
|
There was a problem hiding this comment. This only sets
Suggested change
|
||||||||
| if (fileWarnings.length > 0) { | ||||||||
| sessionStorage.setItem("quorum_file_warnings", JSON.stringify(fileWarnings)) | ||||||||
| } | ||||||||
|
Comment on lines
326
to
+399
There was a problem hiding this comment.
|
||||||||
| files.forEach((f) => { if (f.preview) URL.revokeObjectURL(f.preview) }) | ||||||||
| router.push("/chat") | ||||||||
| } finally { | ||||||||
|
|
@@ -503,6 +518,16 @@ export default function Home() { | |||||||
| <span className="text-[10px] sm:text-xs font-mono font-medium text-zinc-900 dark:text-zinc-100">1,250</span> | ||||||||
| </motion.div> | ||||||||
|
|
||||||||
| <motion.button | ||||||||
| whileTap={{ scale: 0.95 }} | ||||||||
| whileHover={{ scale: 1.05 }} | ||||||||
| onClick={() => setShowSettings(true)} | ||||||||
| className={cn("w-7 h-7 sm:w-8 sm:h-8 rounded-full bg-zinc-100 dark:bg-zinc-800 flex items-center justify-center border border-zinc-200 dark:border-zinc-700 hover:bg-zinc-200 dark:hover:bg-zinc-700 transition-all shadow-sm", theme === "lovelace" && "hover:ring-[1.5px] hover:ring-[#eb6f92]/60", theme === "tokyonight" && "hover:ring-[1.5px] hover:ring-[#7aa2f7]/40", theme === "gruvbox" && "hover:ring-[1.5px] hover:ring-[#fe8019]/50", theme === "catppuccin" && "hover:ring-[1.5px] hover:ring-[#cba6f7]/50", theme === "nord" && "hover:ring-[1.5px] hover:ring-[#88c0d0]/50", theme === "solarized" && "hover:ring-[1.5px] hover:ring-[#073642]/50")} | ||||||||
| aria-label={t[locale].settings} | ||||||||
| > | ||||||||
| <Settings2 className="w-3.5 h-3.5 text-zinc-600 dark:text-zinc-400" /> | ||||||||
| </motion.button> | ||||||||
|
|
||||||||
| <div className="relative" data-header-dropdown> | ||||||||
| <motion.button | ||||||||
| whileTap={{ scale: 0.95 }} | ||||||||
|
|
@@ -522,14 +547,6 @@ export default function Home() { | |||||||
| className="absolute top-full right-0 mt-2 w-48 bg-card border border-border rounded-xl shadow-lg overflow-hidden z-[60]" | ||||||||
| > | ||||||||
| <div className="p-1"> | ||||||||
| <button | ||||||||
| onClick={() => { setShowDropdown(false); signOut() }} | ||||||||
| className="w-full flex items-center gap-2 px-3 py-2 text-sm text-red-600 dark:text-red-400 hover:bg-red-50 dark:hover:bg-red-900/20 rounded-lg transition-colors" | ||||||||
|
|
||||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -6,10 +6,11 @@ | |||||
| import { Send, Square, Paperclip, X, FileText, File, Loader2 } from "lucide-react" | ||||||
| import { cn } from "@/lib/utils" | ||||||
| import { parseFile, SUPPORTED_EXTENSIONS } from "@/lib/file-parser" | ||||||
| import type { ParseWarning } from "@/lib/file-parser" | ||||||
|
Check warning on line 9 in src/components/MessageInput.tsx
|
||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| const translations = { | ||||||
| en: { placeholder: "Type your message...", send: "Send", stop: "Stop", attach: "Attach file", parsing: "Reading files...", unsupported: "Supported: PDF, DOCX, Excel, and text files", truncated: (name: string) => `"${name}" is too long - only the first ~20 pages were included`, empty: (name: string) => `"${name}" appears to be scanned/empty - no text could be extracted` }, | ||||||
| ko: { placeholder: "메시지를 입력하세요...", send: "보내기", stop: "중지", attach: "파일 첨부", parsing: "파일 읽는 중...", unsupported: "지원 형식: PDF, DOCX, Excel, 텍스트 파일", truncated: (name: string) => `"${name}" 파일이 너무 길어 앞부분만 포함되었습니다`, empty: (name: string) => `"${name}" 파일에서 텍스트를 추출할 수 없습니다 (스캔 문서일 수 있음)` }, | ||||||
| } | ||||||
|
|
||||||
| interface AttachedFile { | ||||||
|
|
@@ -23,11 +24,13 @@ | |||||
| onStop, | ||||||
| disabled, | ||||||
| locale, | ||||||
| initialFileWarning, | ||||||
| }: { | ||||||
| onSend: (text: string, target: Provider | "all") => void | ||||||
| onStop: () => void | ||||||
| disabled: boolean | ||||||
| locale: Locale | ||||||
| initialFileWarning?: string | null | ||||||
| }) { | ||||||
| const [text, setText] = useState("") | ||||||
| const [isDragging, setIsDragging] = useState(false) | ||||||
|
|
@@ -66,16 +69,26 @@ | |||||
| let messageText = text.trim() | ||||||
|
|
||||||
| if (attachedFiles.length > 0) { | ||||||
| const warnings: string[] = [] | ||||||
| const results = await Promise.allSettled( | ||||||
| attachedFiles.map(async (af) => { | ||||||
| const parsed = await parseFile(af.file) | ||||||
| if (parsed.warning === 'empty') { | ||||||
|
Comment on lines
+72
to
+76
There was a problem hiding this comment.
|
||||||
| warnings.push(t.empty(af.file.name)) | ||||||
| return null | ||||||
| } | ||||||
| if (parsed.warning === 'truncated') { | ||||||
| warnings.push(t.truncated(af.file.name)) | ||||||
| } | ||||||
| if (parsed.text && !parsed.text.startsWith('[Unsupported')) { | ||||||
| return `--- File: ${af.file.name} ---\n${parsed.text}` | ||||||
| } | ||||||
| return null | ||||||
| }) | ||||||
| ) | ||||||
|
|
||||||
| if (warnings.length > 0) setFileError(warnings.join('\n')) | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| const fileContents = results.map((r, i) => { | ||||||
| if (r.status === "fulfilled" && r.value) return r.value | ||||||
| if (r.status === "rejected") { | ||||||
|
|
@@ -111,10 +124,15 @@ | |||||
| } | ||||||
| } | ||||||
|
|
||||||
| // Show initial file warning passed from homepage | ||||||
| useEffect(() => { | ||||||
| if (initialFileWarning) setFileError(initialFileWarning) | ||||||
| }, [initialFileWarning]) | ||||||
|
|
||||||
| // Auto-dismiss file error | ||||||
| useEffect(() => { | ||||||
| if (!fileError) return | ||||||
| const timer = setTimeout(() => setFileError(null), 5000) | ||||||
| return () => clearTimeout(timer) | ||||||
| }, [fileError]) | ||||||
|
|
||||||
|
|
@@ -204,7 +222,7 @@ | |||||
| className="group relative flex items-center gap-2 p-2 bg-zinc-50 dark:bg-zinc-800/50 border border-zinc-200 dark:border-zinc-700 rounded-xl" | ||||||
| > | ||||||
| {file.preview ? ( | ||||||
| <img src={file.preview} alt="" className="w-8 h-8 rounded-lg object-cover" /> | ||||||
|
Check warning on line 225 in src/components/MessageInput.tsx
|
||||||
| ) : file.file.type.includes("pdf") ? ( | ||||||
| <FileText className="w-4 h-4 text-red-500" /> | ||||||
| ) : ( | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,20 +7,31 @@ const MAX_FILE_CHARS = 50000 | |
|
|
||
| export const SUPPORTED_EXTENSIONS = new Set(["pdf", "docx", "xlsx", "xls", "txt", "md", "csv"]) | ||
|
|
||
| export type ParseWarning = "truncated" | "empty" | ||
|
|
||
| export interface ParseResult { | ||
| text: string | ||
| warning?: ParseWarning | ||
| } | ||
|
|
||
| export async function parseFile(file: File): Promise<ParseResult> { | ||
| const ext = file.name.split('.').pop()?.toLowerCase() ?? '' | ||
|
|
||
| let result: string | ||
| if (ext === 'pdf') result = await parsePDF(file) | ||
| else if (ext === 'docx') result = await parseDOCX(file) | ||
| else if (ext === 'xlsx' || ext === 'xls') result = await parseExcel(file) | ||
| else if (ext === 'txt' || ext === 'md' || ext === 'csv') result = await parseText(file) | ||
| else return { text: `[Unsupported file type: ${file.name}]` } | ||
|
|
||
| if (!result.trim()) { | ||
| return { text: '', warning: 'empty' } | ||
| } | ||
|
|
||
| if (result.length > MAX_FILE_CHARS) { | ||
| return { text: result.slice(0, MAX_FILE_CHARS) + '\n[...file truncated]', warning: 'truncated' } | ||
| } | ||
|
Comment on lines
+27
to
33
There was a problem hiding this comment. New warning behavior ( |
||
| return { text: result } | ||
| } | ||
|
|
||
| async function parseText(file: File): Promise<string> { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JSON.parse(warningsRaw).join("\n")assumes the stored value parses to an array. If it parses to a non-array (or array contains non-strings), this will throw and warnings will be silently dropped. Consider validating withArray.isArray(...)and string-coercing/filtering elements before joining. Also note that\nwon’t render as line breaks in the toast unless you applywhite-space: pre-line(or render as a list).