-
Notifications
You must be signed in to change notification settings - Fork 9
Consolidate AWB preview handling #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e37deff
Make AWB a soft dependency
yakutovicha 323f625
Merge branch 'main' into update/make-awb-soft-dependency
yakutovicha 9752d0b
Update home/node_preview.py
yakutovicha 8bad9eb
Simplify node_preview module
yakutovicha 4f4880a
Remove test_process_module_does_not_import_awb_directly
yakutovicha 5aa52b7
Node preview and AWB_UNAVAILABLE_MESSAGE
yakutovicha 518e609
fix tests
yakutovicha 91e78a7
Better highlight pip instal ...
yakutovicha 3165788
Update AWB_UNAVAILABLEP_MESSAGE
yakutovicha 3d23670
Update home/node_preview.py
yakutovicha 5b2c03c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| """Helpers for optional node previews.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from aiida import orm | ||
|
|
||
| AWB_UNAVAILABLE_MESSAGE = ( | ||
| "The AiiDAlab widgets are not available. Please install it with " | ||
| "`pip install aiidalab-widgets-base` to use this feature." | ||
| ) | ||
|
|
||
|
|
||
| def _load_awb_viewer(): | ||
| from aiidalab_widgets_base import viewer # noqa: PLC0415 | ||
|
|
||
| return viewer | ||
|
|
||
|
|
||
| def render_unavailable_preview() -> str: | ||
| """Return the fallback message shown when AWB is unavailable.""" | ||
| return AWB_UNAVAILABLE_MESSAGE | ||
|
|
||
|
|
||
| def render_node_preview(node: orm.Node) -> object: | ||
|
yakutovicha marked this conversation as resolved.
Outdated
|
||
| """Render a node preview using AWB when it is available.""" | ||
| try: | ||
| viewer = _load_awb_viewer() | ||
| except ImportError: | ||
| return render_unavailable_preview() | ||
|
|
||
| return viewer(node) | ||
|
yakutovicha marked this conversation as resolved.
Outdated
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.