Fixing modes animation in case of reducible supercell - #164
Open
mikibonacci wants to merge 3 commits into
Open
Conversation
mikibonacci
changed the title
Member
|
How can I reproduce this issue ? Because the modes are displayed on the primitive used |
Member
Author
|
I will send you a node and a notebook to reproduce |
| if vibro is None: | ||
| return None | ||
|
|
||
| if "numerical_accuracy_4" in vibro.get("vibrational_data", {}): |
Member
There was a problem hiding this comment.
use the function get_vibrational_data, from the RamanModel instead
| return None | ||
|
|
||
|
|
||
| def fix_eigenvectors_dimensions(model): |
Member
There was a problem hiding this comment.
Move this logic to the model , also in the Mode
deleting the print from the fix modes function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #163