Skip to content

Update pyproject.toml #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikibonacci merged 1 commit into from
May 22, 2026
Merged

Update pyproject.toml #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "flit_core.buildapi"

[project]
name = "aiidalab-qe-vibroscopy"
description="AiiDAlab QE plugin for vibrational spectoscopies."
description="AiiDAlab QE plugin for vibrational spectroscopies."
version = "1.2.4"
authors = [
{name = "Miki Bonacci", email = "miki.bonacci@psi.ch"},
Expand All @@ -18,11 +18,10 @@ classifiers = [
keywords = ["aiidalab", "plugin"]
requires-python = ">=3.8"
dependencies = [
"aiida-vibroscopy==1.3.0",
"aiida-phonopy==1.2.1",
"aiida-pythonjob==0.2.5",
"pre-commit",
"euphonic==1.3.0",
"aiida-vibroscopy~=1.3.0",
"aiida-phonopy~=1.2.1",

@danielhollas danielhollas May 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning to minor versions is possibly still problematic, since any updates then need to be coordinated between all plugins at once (for common dependencies)

@AndresOrtegaGuerrero AndresOrtegaGuerrero May 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus we should aimed to introducing aiida-vibroscopy latest for the newest implementations

@edan-bainglass edan-bainglass May 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielhollas I don't quite understand. Can you clarify what you're suggesting here? Note that there is complexity here in any case, as often AiiDA plugin developers move faster than AiiDAlab plugin developers.

@danielhollas danielhollas May 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, it's probably wise to pin to minor versions.

This PR is mostly about unpinning the patch versions.

"aiida-pythonjob~=0.2.5",
"euphonic~=1.3.0",
"kaleido",
"weas-widget>=0.2.6"
]
Expand Down
Loading