Skip to content

Pin aiida-hyperqueue version in Dockerfile - #1349

Merged
superstar54 merged 1 commit into
aiidalab:mainfrom
superstar54:pin_aiida_hyperqueue_version
Jul 24, 2025
Merged

Pin aiida-hyperqueue version in Dockerfile#1349
superstar54 merged 1 commit into
aiidalab:mainfrom
superstar54:pin_aiida_hyperqueue_version

Conversation

@superstar54

@superstar54 superstar54 commented Jul 24, 2025

Copy link
Copy Markdown
Member

aiida-hyperqueue 0.3.0 is released, but it needs aiida-core >=2.7, so we pin it to 0.2.1 in the current Dockerfile.

This fixes the failed tests build-test as shown here: https://github.com/aiidalab/aiidalab-qe/actions/runs/16493448398/job/46634450814?pr=1343

@edan-bainglass edan-bainglass left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you reference the relevant issue(s)? 🙏

@codecov

codecov Bot commented Jul 24, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.28%. Comparing base (f7033a7) to head (391375b).
⚠️ Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1349      +/-   ##
==========================================
+ Coverage   72.26%   72.28%   +0.01%     
==========================================
  Files          99       99              
  Lines        6894     6894              
==========================================
+ Hits         4982     4983       +1     
+ Misses       1912     1911       -1     
Flag Coverage Δ
python-3.11 72.28% <ø> (+0.01%) ⬆️
python-3.9 72.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@superstar54

Copy link
Copy Markdown
Member Author

Sure, I created a new issue for this: #1350. And mentioned the issue when testing the app with aiida-core 2.7.

@superstar54
superstar54 merged commit 36bca1a into aiidalab:main Jul 24, 2025
9 checks passed
@superstar54
superstar54 deleted the pin_aiida_hyperqueue_version branch July 24, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants