Skip to content

Image cleanup - #1421

Closed
edan-bainglass wants to merge 2 commits into
aiidalab:mainfrom
edan-bainglass:image-cleanup
Closed

Image cleanup#1421
edan-bainglass wants to merge 2 commits into
aiidalab:mainfrom
edan-bainglass:image-cleanup

Conversation

@edan-bainglass

Copy link
Copy Markdown
Member

This PR attempts to add some cleanup prior to image build and reduce cache explosion to reduce image size, which is currently failing all tests due to size limit exceeding.

@edan-bainglass

Copy link
Copy Markdown
Member Author

@danielhollas I'm trying a few things, but I'm confident I don't understand this side of things well enough 😅 Nevertheless, the problem remains. All recent PRs fail due to size limits. Thoughts?

@codecov

codecov Bot commented Nov 20, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.20%. Comparing base (4e1ceb2) to head (96b9fce).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1421      +/-   ##
==========================================
+ Coverage   72.18%   72.20%   +0.01%     
==========================================
  Files         108      108              
  Lines        7259     7259              
==========================================
+ Hits         5240     5241       +1     
+ Misses       2019     2018       -1     
Flag Coverage Δ
python-3.11 72.18% <ø> (+0.01%) ⬆️
python-3.9 72.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danielhollas danielhollas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't run into this problem before. Just one quick thought, it's perhaps worth trying to bump docker/build-push-action@v5 to docker/build-push-action@v6.
Otherwise the most straightforward way is to simply disable caching (to at least see if that fixes things?).

I also think somebody should invest time in addressing the root problem and slim down the image. Last time I looked there was possibly a lot of low-hanging fruit, I started looking into it in #1337, please have a look at that PR (I've revived it today and made a bit of progress but will not have time to pursue it tomorrow).

@edan-bainglass

Copy link
Copy Markdown
Member Author

@superstar54 effort is already underway in #1337 by @danielhollas. This PR is another attempt at resolving the issue of dealing with a massive image. Let's discuss at the coding week.

@danielhollas

Copy link
Copy Markdown
Contributor

@edan-bainglass I think this one can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants