Skip to content

Check blocked state only if not confirmed - #1541

Merged
edan-bainglass merged 1 commit into
mainfrom
no-block-if-complete
Jul 6, 2026
Merged

Check blocked state only if not confirmed#1541
edan-bainglass merged 1 commit into
mainfrom
no-block-if-complete

Conversation

@edan-bainglass

Copy link
Copy Markdown
Member

We were checking for a blocked state first, which applies also to completed jobs.
This PR moves blocking state checks after completion checks, to avoid blocking
already finished jobs.

Blocking such jobs SHOULD NOT happen in principle, but it can happen due to
bugs. This PR ensures at least that users aren't blocked for such reasons. The
blockers still appear (so we can still detect bugs), but now they don't block the
wizard.

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.32%. Comparing base (17f549a) to head (06842f0).

Files with missing lines Patch % Lines
src/aiidalab_qe/app/configuration/model.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1541   +/-   ##
=======================================
  Coverage   75.32%   75.32%           
=======================================
  Files         115      115           
  Lines        7388     7388           
=======================================
  Hits         5565     5565           
  Misses       1823     1823           
Flag Coverage Δ
python-3.12 75.32% <88.88%> (ø)
python-3.9 75.35% <88.88%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AndresOrtegaGuerrero AndresOrtegaGuerrero left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! , I wonder is there is a possibility to include a small test to check the change of the states ,?

@edan-bainglass
edan-bainglass merged commit 0ef6606 into main Jul 6, 2026
11 checks passed
@edan-bainglass
edan-bainglass deleted the no-block-if-complete branch July 6, 2026 11:43
@edan-bainglass

Copy link
Copy Markdown
Member Author

LGTM! , I wonder is there is a possibility to include a small test to check the change of the states ,?

Sure. There are several things that could benefit from extending our testing suite. I'll try to revisit this soon 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants