Remove home app from the registry - #147
Merged
Merged
Conversation
Contributor
Author
|
Thanks Edan. I'll wait for @yakutovicha approval before merging. Should also probably test that it doesn't break the home app, but would need to figure out how. |
Member
|
Pinging @yakutovicha |
Member
|
I think it is fine, the app is part of the Docker file already, I see no way this breaks it. |
yakutovicha
approved these changes
May 26, 2026
Contributor
Author
|
Alright, I am going to go ahead and merge. I am not sure how often the registry is rebuild, but we should keep an eye and be prepared to revert this if things break. 😅 |
Contributor
Author
|
Okay, I think the home is now removed from the registry since I no longer see it in the list of apps at https://aiidalab.github.io/aiidalab-registry/index.html I've logged in into a fresh instance of the demo server and it loaded fine so I think we're good here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #146, see the issue for details