Skip to content

Test aiida 2.7 - #698

Merged
danielhollas merged 17 commits into
aiidalab:masterfrom
danielhollas:aiida-2.7
Aug 5, 2025
Merged

Test aiida 2.7#698
danielhollas merged 17 commits into
aiidalab:masterfrom
danielhollas:aiida-2.7

Conversation

@danielhollas

@danielhollas danielhollas commented May 6, 2025

Copy link
Copy Markdown
Contributor

Both notebook tests and unit tests are updated to use aiida-core 2.7.1.

@codecov

codecov Bot commented May 6, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.29%. Comparing base (3f9e956) to head (2c9d850).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #698   +/-   ##
=======================================
  Coverage   84.29%   84.29%           
=======================================
  Files          18       18           
  Lines        3584     3584           
=======================================
  Hits         3021     3021           
  Misses        563      563           
Flag Coverage Δ
python-3.11 84.29% <ø> (ø)
python-3.9 84.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@agoscinski

agoscinski commented May 6, 2025

Copy link
Copy Markdown

Some of the errors I think are related to the usage tempfile.mkdtemp (only checked the export_aiida_subgraph so far), I at least remember that I also had issues with this. That it was already removed when I created it, so I switched to the pytest fixture or tempfile.TemporaryDirectory. It might be related due to an update in the dependencies of aiida-core.

@danielhollas

danielhollas commented May 6, 2025

Copy link
Copy Markdown
Contributor Author

I think it has something to do with the profile management. The actual error from the export_aiida_subgraph is comes from a failing verdi archive create command, which complains that a profile is not set.

Command '['verdi', 'archive', 'create', '/tmp/pytest-of-runner/pytest-0/test_export_button_widget0/export.aiida', '-N', '5']' returned non-zero exit status 1.
b"Critical: no default profile defined: None\n{'CONFIG_VERSION': {'CURRENT': 9, 'OLDEST_COMPATIBLE': 9}, 'profiles': {'909900f38064e37d3f242f6336098653': {'storage': {'backend': 'core.sqlite_dos', 'config': {'filepath': '/tmp/pytest-of-runner/pytest-0/test_sqlite_dos_storage0'}}, 'process_control': {'backend': 'core.rabbitmq', 'config': {'broker_protocol': 'amqp', 'broker_username': 'guest', 'broker_password': 'guest', 'broker_host': '127.0.0.1', 'broker_port': 5672, 'broker_virtual_host': ''}}, 'test_profile': True, 'PROFILE_UUID': '53e42cace0c14a31816a52dbd0a11632', 'options': {}, 'default_user_email': 'test@localhost'}}}\n"

Comment thread tests/test_process.py
# Test the widget can be instantiated with empty inputs
awb.ProcessReportWidget()

# Stopping the daemon and submitting the process.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small simplification


# Test select a new resource setup will update the output interface (e.g. ssh_config, computer_setup, code_setup)
# and the computer/code setup widget will be updated accordingly.
w.comp_resources_database.domain_selector.value = "merlin.psi.ch"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was super-painful to fix (these tests now fail on master as well). Really these tests should be rewritten to use mocked-out data instead of real data that can change at any moment.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielhollas
danielhollas marked this pull request as ready for review August 4, 2025 21:37

@superstar54 superstar54 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danielhollas
danielhollas merged commit 03c29dc into aiidalab:master Aug 5, 2025
11 checks passed
@danielhollas
danielhollas deleted the aiida-2.7 branch August 5, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants