added axes, zoom and pan control - #745
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #745 +/- ##
==========================================
+ Coverage 84.77% 85.12% +0.34%
==========================================
Files 18 18
Lines 3336 3421 +85
==========================================
+ Hits 2828 2912 +84
- Misses 508 509 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielhollas
left a comment
There was a problem hiding this comment.
tbh I am not sure I am a fan of this PR, especially the inline JS code which seems like it will be very hard to maintain.
It seems like bigger features like this should be discussed in an issue before implementation.
Also I wonder how does this relate to the work on WEAS widget in #559?
| cell: ase.cell.Cell object. | ||
| """ | ||
|
|
||
| show_axes = tl.Bool(True) |
There was a problem hiding this comment.
To preserve the backwards compatibility, it would be better to not show axes by default (for example in AtmoSpec I don't want them).
There was a problem hiding this comment.
Hi @danielhollas, I agree that we should discuss. Let's discuss this at the next meeting, to understand when we will have the weas widget, and how we can quickly switch back to a more intuitive default orientation.
|
I will fix pan functionality after merging of #742 |
This pull request introduces a comprehensive set of enhancements to the
StructureDataViewerinaiidalab_widgets_base/viewers.py, focusing on improved view controls, axis visualization, and test coverage. The changes add user controls for view scaling, panning, and axes display, as well as robust validation and reset mechanisms. Corresponding tests ensure these features work as intended.Key improvements and new features:
Viewer controls and UI enhancements:
Axes visualization:
View transformation logic:
Test coverage:
Minor UI improvements:
These changes collectively provide a more interactive and user-friendly structure viewer, with fine-grained control over visualization and improved test reliability.
Screen.Recording.2026-05-18.at.16.19.52.mov