Fix imported viewer representation arrays - #766
Open
cpignedoli wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #766 +/- ##
==========================================
+ Coverage 85.03% 85.18% +0.14%
==========================================
Files 18 18
Lines 3335 3335
==========================================
+ Hits 2836 2841 +5
+ Misses 499 494 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a structure-viewer crash when an incoming
ase.Atomsobject already contains an_aiidalab_viewer_representation_*array that is not present in the current viewer representation list.Root Cause
StructureDataViewer._observe_structurecorrectly iterated over the incoming representationstyle_id, but the unknown-representation branch tried to readstructure.arrays[self.style_id].StructureDataViewerhas nostyle_idattribute, so importing/changing to a structure carrying representation arrays raisedAttributeError.This can happen in downstream apps when a structure previously modified by representation controls is reused or when switching between structures after applying custom representations.
Changes
style_idwhen importing an unknown representation array.Validation
python -m pytest tests/test_viewers.py::test_structure_data_viewer_imports_unknown_representation_array tests/test_viewers.py::test_structure_data_viewer_representationpython -m pytest tests/test_viewers.pyImplemented with Codex.