PR-R2: Load viewer representations from extras - #769
Open
cpignedoli wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/encoded-representation-style-ids #769 +/- ##
============================================================================
- Coverage 85.40% 85.35% -0.06%
============================================================================
Files 18 18
Lines 3379 3393 +14
============================================================================
+ Hits 2886 2896 +10
- Misses 493 497 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cpignedoli
marked this pull request as ready for review
June 25, 2026 08:42
cpignedoli
marked this pull request as draft
June 25, 2026 08:43
cpignedoli
marked this pull request as ready for review
June 25, 2026 09:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PR-R2 in the representation split. This is stacked on top of #768 (
feature/encoded-representation-style-ids).This PR teaches the structure viewer/manager to read viewer representation masks from AiiDA node extras and to clean stale representation rows when switching between structures.
Why
Encoded representation arrays already survive file upload/download, but stored AiiDA nodes need an extras-based path because
get_ase()does not preserve custom viewer state by itself.This PR intentionally only reads/restores that state. Writing it is kept for the next PR in the chain.
Chain
Implemented with Codex.
Validation
Result: 35 passed, 20 warnings.