Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## support-py3.14 #7244 +/- ##
==================================================
- Coverage 79.71% 79.70% -0.00%
==================================================
Files 565 565
Lines 43862 43863 +1
==================================================
- Hits 34959 34957 -2
- Misses 8903 8906 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
agoscinski
force-pushed
the
drop-py3.9
branch
4 times, most recently
from
7ef644f to
852f0b3
Compare
- Fix of linter error RUF007 - Fix the pre-commit hook generate-conda-environment that hardcoded the python version when generating the environment.yaml - Bump `flask-cors` to ~=4.0 to fix `collections.Iterable` removal in Python 3.10+
| - defaults | ||
| dependencies: | ||
| - python~=3.9 | ||
| - python>=3.10 |
There was a problem hiding this comment.
Doesn't this make more sense rather than python~=3.10? Its consistent with our pyproject.toml. I feel like there was a reason for it but I cannot guess it.
|
Regarding codecov patch failing, I would add a test in a different PR . It does not make sense to add tests here, but I find it worrisome enough that the code section is not tested at all |
danielhollas
added
pr/blocked
|
We can probably also drop the |
| if labels[-1][0] != len(bands) - 1: | ||
| labels.append((len(bands) - 1, '')) | ||
| for (position_from, label_from), (position_to, label_to) in zip(labels[:-1], labels[1:]): | ||
| for (position_from, label_from), (position_to, label_to) in itertools.pairwise(labels): |
|
Any blockers here? (asking since mypy 1.20 came out today and dropped support for python 3.9). Also merging this would make working with typing easier (could finally use the union operator :-) ) (@GeigerJ2) |
2 participants
Based on branch in PR #7240
I realized that our tox.ini is not updated for new python versions. I think no one is using it? I would try replace it actually with hatch since its developed by PyPA, it has the potential to replace multiple dev tools with one interface, and more important some people in our lab already use it and are familiar with it.
After this PR is merged, we need to update the branch protection rules.
Remember to delete base, since py3.14 PR is using branch on my fork