Bump propcache from 0.4.1 to 0.5.2#1710
Conversation
Merging this PR will degrade performance by 12.66%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | test_empty_query |
44.3 µs | 53.9 µs | -17.8% |
| ❌ | test_query |
44.4 µs | 53.8 µs | -17.52% |
| ❌ | test_query_string |
45.1 µs | 54.7 µs | -17.51% |
| ❌ | test_empty_query_string |
44.9 µs | 54.1 µs | -17.05% |
| ❌ | test_empty_path_safe |
49.2 µs | 58.6 µs | -15.95% |
| ❌ | test_empty_path |
49.2 µs | 58.5 µs | -15.92% |
| ❌ | test_raw_path_qs_with_query |
50.7 µs | 60.1 µs | -15.59% |
| ❌ | test_empty_raw_path_qs |
50.5 µs | 59.8 µs | -15.44% |
| ❌ | test_raw_path_qs |
50.7 µs | 59.6 µs | -14.98% |
| ❌ | test_path_safe |
51.5 µs | 58.8 µs | -12.51% |
| ❌ | test_url_host_port_subcomponent |
451.6 µs | 514.1 µs | -12.16% |
| ❌ | test_url_origin_with_user_pass |
76.7 µs | 86.2 µs | -11.04% |
| ❌ | test_url_with_path_origin |
77.3 µs | 86.8 µs | -10.93% |
| ❌ | test_url_origin |
77.2 µs | 86.6 µs | -10.82% |
| ❌ | test_is_default_port |
165.2 µs | 183.1 µs | -9.79% |
| ❌ | test_empty_query_string_uncached |
72.3 µs | 79.5 µs | -8.98% |
| ❌ | test_empty_path_safe_uncached |
80.9 µs | 88.3 µs | -8.45% |
| ❌ | test_url_with_password |
300.5 µs | 328.1 µs | -8.41% |
| ❌ | test_url_with_port |
307.4 µs | 334.3 µs | -8.04% |
| ❌ | test_url_with_user |
299.3 µs | 324.8 µs | -7.86% |
| ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing dependabot/pip/propcache-0.5.2 (cdf896e) with master (ccd2648)1
Footnotes
|
might be a real regression .. need to check |
|
@dependabot recreate |
3c26019 to
73a816f
Compare
|
regression is real but I think its Cython as nothing of substance has changed in propcache |
@bdraco Incase I did propose one time to try migrating the project to C at some point, but a second option I have is that we could bring this up with the Cython developers incase there were any hiccups in the newer code generation. |
|
@bdraco I'm wondering if the Cython version is still being pinned after the Oh, and if we get to return to |
6f30882 to
b20f88c
Compare
Yes, its a problem. All sorted now
There is specific logic to disable the cache on pre-release builds added |
adb16cc to
f6e2a9a
Compare
Coverage Report for CI Build 27616098591Coverage remained the same at 98.74%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
f6e2a9a to
1d5f432
Compare
|
Regression is still visible I would recommend aio-libs/propcache#245 Which seeks to defend against these regressions using a small amount of C code. |
f334a08 to
1970ad2
Compare
1970ad2 to
b42f312
Compare
b42f312 to
29eb4d0
Compare
Bumps [propcache](https://github.com/aio-libs/propcache) from 0.4.1 to 0.5.2. - [Release notes](https://github.com/aio-libs/propcache/releases) - [Changelog](https://github.com/aio-libs/propcache/blob/master/CHANGES.rst) - [Commits](aio-libs/propcache@v0.4.1...v0.5.2) --- updated-dependencies: - dependency-name: propcache dependency-version: 0.5.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
29eb4d0 to
cdf896e
Compare
Bumps propcache from 0.4.1 to 0.5.2.
Release notes
Sourced from propcache's releases.
... (truncated)
Changelog
Sourced from propcache's changelog.
... (truncated)
Commits
041f7afRelease 0.5.2 (#222)9c374aaRelease 0.5.1 (#221)c4e2b78Skip cibuildwheel test on free threaded armv7l musllinux (#220)e60bdedRelease 0.5.0 (#219)b88f846Make wheel builds reproducible (#218)fdacd6cUpdate Typehint annotations (#193)483e9d3[pre-commit.ci] pre-commit autoupdate (#204)d0d45e1Drop Python 3.9 support (#216)c0bacf5Update pytest-cov requirement from >=2.3.1 to >=7.1.0 (#210)9bfb3e4Bump pytest-codspeed from 4.3.0 to 4.5.0 (#211)