validate idna-encoded host against reg-name in _encode_host#1743
Draft
alhudz wants to merge 1 commit into
Draft
Conversation
psf-chronographer
Bot
added
the
bot:chronographer:provided
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1743 +/- ##
==========================================
+ Coverage 99.86% 99.90% +0.04%
==========================================
Files 21 21
Lines 4310 4318 +8
Branches 252 253 +1
==========================================
+ Hits 4304 4314 +10
+ Misses 4 2 -2
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
gentle ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_encode_host validates ASCII hosts against the reg-name grammar but sends non-ASCII hosts straight through _idna_encode, whose IDNA 2003 stdlib codec fallback does not reject reserved characters. A host like user:pass@bücher.example then keeps its @, : or / and yields a confusable authority. Running the same NOT_REG_NAME check on the encoded ASCII result makes with_host and URL.build reject these, while valid IDN hosts still encode normally. Fixes #955.