adding attributes field to MetaData for GroupBy and Join#1026
Open
PolinaRodimova wants to merge 1 commit intoairbnb:mainfrom
Open
adding attributes field to MetaData for GroupBy and Join#1026PolinaRodimova wants to merge 1 commit intoairbnb:mainfrom
PolinaRodimova wants to merge 1 commit intoairbnb:mainfrom
Conversation
hzding621
requested changes
Aug 21, 2025
Collaborator
hzding621
left a comment
There was a problem hiding this comment.
Today, kwargs is passed in GroupBy and Join which is saved in custom_json in metadata. It's intended that companies/users leverage kwargs and custom_json for their custom metadata, so I think we may not need to introduce another attributes parameter here. In your internal code, you can create wrappers for GroupBy/Join Python APIs with more explicit parameters for your custom metadata.
Collaborator
@PolinaRodimova - if you go down the customJson route, could you please make a doc change for posterity's sake? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding attributes field to metadata for GroupBy and Join to pass company specific information
Why / Goal
Allow to passthrough some custom and company related information without adding dedicated fields
Test Plan
Checklist
Reviewers