Skip to content

docs(source-bing-ads): fix changelog date and remove invalid JSON comment#76111

Draft
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin/1775520751-docs-source-bing-ads
Draft

docs(source-bing-ads): fix changelog date and remove invalid JSON comment#76111
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin/1775520751-docs-source-bing-ads

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot commented Apr 7, 2026

Documentation Confidence Assessment

Overall Confidence: 4/5

Dimension Score Rationale
Code Comprehension 4/5 Manifest-only connector with well-documented custom components for report downloading.
API Documentation Quality 3/5 Microsoft docs cover auth and reporting endpoints but omit rate limits and SAS token TTL details.
Change Scope & Risk 5/5 Changelog date correction and removal of an invalid JSON comment; 3 lines changed total.
Existing Doc Maturity 5/5 Mature 463-line doc with comprehensive coverage of setup, streams, custom reports, and troubleshooting.
Connector Sensitivity 2/5 Certified connector with ql=400, sl=300 (high-usage).
Triggering Context 5/5 Triggered from a small, merged bug-fix PR.

What I Verified vs. What I Inferred

  • Verified from code: PR #76053 merge commit 0c495b5 has timestamp 2026-04-06 17:07:55 -0700, confirming the correct changelog date is 2026-04-06.
  • Verified from API docs: JSON does not support // comments; the example would fail if copy-pasted into a connector config.
  • Verified from doc context: The explanatory text at lines 283–285 already conveys the same information as the removed comment ("The second report will be named another_report (default conversion applied)").
  • Inferred: Nothing inferred — both changes are mechanically verifiable.

Areas of Concern

None identified.


What

Fixes two documentation issues in the Bing Ads source connector docs:

  1. Incorrect changelog date for v2.23.15-rc.3 (set by /bump-version on the run date, not the actual merge date of #76053)
  2. Invalid // comment inside a JSON code example that would cause parse errors if copy-pasted

How

  1. Changelog date: 2026-04-022026-04-06 to match the actual merge date of PR fix(source-bing-ads): fix SAS token expiry during report downloads by re-polling for fresh URL #76053 (commit 0c495b5 timestamp: 2026-04-06 17:07:55 -0700).
  2. JSON example: Removed the // This report will use default conversion: another_report line. JSON does not support comments; the same information is already conveyed in the explanatory text below the code block ("The second report will be named another_report (default conversion applied)").

Review guide

  1. docs/integrations/sources/bing-ads.md — both changes are in this file

Human review checklist:

  • Verify 2026-04-06 matches the merge date of #76053
  • Confirm no information is lost by removing the JSON comment (the text at lines 283–285 covers it)

User Impact

Users who copy the custom reports JSON example will no longer get invalid JSON. The changelog accurately reflects when v2.23.15-rc.3 was released.

Can this PR be safely reverted and rolled back?

  • YES 💚

Note: I am an AI assistant (Devin) and have proposed these documentation updates based on a review of the connector source code and third-party API documentation. Reviewers may merge, modify, or close this PR as they see fit.

Link to Devin session: https://app.devin.ai/sessions/0392e7a6ff3c47fbbc89a9466dc0ed1b

…ment

Co-Authored-By: bot_apk <apk@cognition.ai>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • 🛠️ Quick Fixes
    • /format-fix - Fixes most formatting issues.
    • /bump-version - Bumps connector versions, scraping changelog description from the PR title.
      • Bump types: patch (default), minor, major, major_rc, rc, promote.
      • The rc type is a smart default: applies minor_rc if stable, or bumps the RC number if already RC.
      • The promote type strips the RC suffix to finalize a release.
      • Example: /bump-version type=rc or /bump-version type=minor
    • /bump-progressive-rollout-version - Alias for /bump-version type=rc. Bumps with an RC suffix and enables progressive rollout.
  • ❇️ AI Testing and Review (internal link: AI-SDLC Docs):
    • /ai-prove-fix - Runs prerelease readiness checks, including testing against customer connections.
    • /ai-canary-prerelease - Rolls out prerelease to 5-10 connections for canary testing.
    • /ai-review - AI-powered PR review for connector safety and quality gates.
  • 🚀 Connector Releases:
    • /publish-connectors-prerelease - Publishes pre-release connector builds (tagged as {version}-preview.{git-sha}) for all modified connectors in the PR.
  • ☕️ JVM connectors:
    • /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
      Example: /update-connector-cdk-version connector=destination-bigquery
  • 🐍 Python connectors:
    • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
    • /poe source example lock - Alias for /poe connector source-example lock.
    • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
    • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.
  • ⚙️ Admin commands:
    • /force-merge reason="<REASON>" - Force merges the PR using admin privileges, bypassing CI checks. Requires a reason.
      Example: /force-merge reason="CI is flaky, tests pass locally"
📚 Show Repo Guidance

Helpful Resources

📝 Edit this welcome message.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Deploy preview for airbyte-docs ready!

✅ Preview
https://airbyte-docs-o97lqhzs9-airbyte-growth.vercel.app

Built with commit ee80e6d.
This pull request is being automatically deployed with vercel-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation Improvements or additions to documentation auto-merge team/documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants