Terraform Cloud

[ajbarea]

Pull Request Overview

This PR updates Terraform version constraints and provider versions, and refines the AWS Cognito resource configuration to address a region-related issue in Terraform Cloud.

• Bump Terraform required_version to >= 1.8.0 and update AWS, local, and archive provider versions.
• Enhance aws_cognito_user_pool_client with token validity units and attribute settings.
• Apply configuration adjustments for Terraform Cloud compatibility.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines	Coverage Δ
backend/app.py	100.00% <100.00%> (ø)
config.py	100.00% <100.00%> (ø)
configure_storage.py	100.00% <100.00%> (ø)
main.py	100.00% <100.00%> (ø)
setup_cognito.py	100.00% <100.00%> (ø)
src/image_processor.py	100.00% <100.00%> (ø)
src/storage_adapter.py	100.00% <100.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull Request Overview

This PR updates Terraform configuration by bumping core and provider versions, introduces new Cognito token validity settings, and standardizes resource tagging. It also refines the AWS Cognito user pool client configuration and adjusts CORS origins.

• Bump Terraform required_version and provider versions for AWS, local, and archive.
• Add Cognito token validity variables with validation and configure aws_cognito_user_pool_client.
• Consolidate common_tags in a local block and apply across resources; adjust CORS and archive settings.

Reviewed Changes

Copilot reviewed 33 out of 35 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
terraform/main.tf	Bumped Terraform core and provider version constraints
terraform/variables.tf	Added Cognito token validity variables with validation rules
terraform/cognito.tf	Enhanced user pool client with token_validity_units and attributes
terraform/locals.tf	Defined local.common_tags for consistent tagging
terraform/s3.tf	Replaced inline tags with local.common_tags
terraform/frontend.tf	Removed duplicate locals, applied local.common_tags
terraform/dynamodb.tf	Replaced inline tags with local.common_tags
terraform/api.tf	Updated CORS origins to CloudFront domain, applied local.common_tags
terraform/lambda.tf	Changed archive to single file, applied local.common_tags

Comments suppressed due to low confidence (7)

terraform/cognito.tf:27

• [nitpick] Most other resources use tags = local.common_tags for consistent tagging. Consider adding a tags block here to help with resource identification and cost allocation.

resource "aws_cognito_user_pool_client" "client" {

backend/README.md:10

• The actual script is named setup_cognito.py, not setup-cognito.py. Update the README to reference the correct filename.

   python setup-cognito.py

tests/test_main.py:241

• The failure test does not verify that the underlying upload function was called. Add mock_upload.assert_called_once_with("file.txt", "bucket", "key") to ensure the error path invokes the storage adapter.

    assert result is False

terraform/lambda.tf:6

• Using source_file here will archive only that single file, omitting any other files or dependencies in the lambda directory. If your Lambda function has multiple modules or assets, consider reverting to source_dir or explicitly including the entire directory.

  source_file = "../lambda/image_processor.py"

frontend/js/components/UploadQueueComponent.js:307

• If .querySelector(".image-modal-body") returns null, this will throw an exception. Add a null check before registering the event handler.

    modalBody.addEventListener("wheel", handleWheel);

frontend/js/auth.js:397

• [nitpick] The removal of the special character requirement weakens password strength. Confirm this change aligns with your security policy or consider reintroducing a stronger validation rule.

    console.log("✅ AuthManager: Password validation passed");

frontend/css/styles.css:147

• [nitpick] Applying flex-wrap: nowrap; on the body may cause overflow and layout issues on smaller screens. Verify responsive behavior or allow wrapping where appropriate.

  flex-wrap: nowrap;