Open
Conversation
Leap is sunsetting their wallet extension. Remove all Leap-related code including wallet connections, @leapwallet/elements liquidity modal, analytics events, CSS styles, test fixtures, and package dependencies from both deploy-web and provider-console apps. Fixes CON-182
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughRemoved Leap wallet integration across the repo: deleted the LiquidityModal, removed Leap deps and registry override, stripped Leap types/CSS/analytics, updated provider wallets, and replaced Leap flows with Keplr in tests and mocks. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -521,7 +521,6 @@ | |||
| "@cosmos-kit/cosmos-extension-metamask": "0.13.3", | |||
Contributor
There was a problem hiding this comment.
🔄 Carefully review the package-lock.json diff
Resolve the comment if everything is ok
- node_modules/@cosmos-kit/leap 2.15.6
- node_modules/@cosmos-kit/leap-extension 2.15.6
- node_modules/@cosmos-kit/leap-metamask-cosmos-snap 0.15.6
- node_modules/@cosmos-kit/leap-mobile 2.14.6
- node_modules/eth-rpc-errors 4.0.3
- node_modules/extension-port-stream 2.1.1
- node_modules/json-rpc-engine 6.1.0
- node_modules/json-rpc-engine/node_modules/@metamask/safe-event-emitter 2.0.0
- node_modules/json-rpc-middleware-stream 4.2.3
- node_modules/@leapwallet/cosmos-snap-provider 0.1.26
- node_modules/@leapwallet/cosmos-snap-provider/node_modules/@cosmjs/proto-signing 0.32.4
- node_modules/@metamask/object-multiplex 1.3.0
- node_modules/@metamask/providers 11.1.2
- node_modules/@metamask/safe-event-emitter 3.1.2
- node_modules/webextension-polyfill 0.10.0 
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3064 +/- ##
==========================================
+ Coverage 60.04% 60.42% +0.37%
==========================================
Files 1036 1035 -1
Lines 24446 24371 -75
Branches 6062 6036 -26
==========================================
+ Hits 14679 14725 +46
+ Misses 8518 8412 -106
+ Partials 1249 1234 -15
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@doc/e2e-manual-qa-checklist.md`:
- Line 165: Update the checklist item that currently reads "Wallet extension
modal opens (Keplr/Cosmostation)" to include MetaMask so it reflects all
supported extensions; locate the checklist line containing "Wallet extension
modal opens (Keplr/Cosmostation)" in doc/e2e-manual-qa-checklist.md and change
it to something like "Wallet extension modal opens
(Keplr/Cosmostation/MetaMask)" or similar to explicitly mention MetaMask.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 39688809-1818-4399-9d03-05f80ef6be5b
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (20)
.gitignore.npmrcapps/deploy-web/package.jsonapps/deploy-web/src/components/get-started/GetStartedStepper.tsxapps/deploy-web/src/components/liquidity-modal/index.tsxapps/deploy-web/src/context/CustomChainProvider/CustomChainProvider.tsxapps/deploy-web/src/pages/get-started/index.tsxapps/deploy-web/src/services/analytics/analytics.service.tsapps/deploy-web/src/styles/index.cssapps/deploy-web/src/types/global.tsapps/deploy-web/tests/ui/fixture/context-with-extension.tsapps/deploy-web/tests/ui/fixture/wallet-setup.tsapps/deploy-web/tests/ui/fixture/web-wallet/initKeplrWebWalletMock.tsapps/deploy-web/tests/ui/fixture/web-wallet/injectWebWallet.tsapps/provider-console/package.jsonapps/provider-console/src/context/CustomChainProvider/CustomChainProvider.tsxapps/provider-console/src/pages/get-started/index.tsxapps/provider-console/src/styles/index.cssdoc/e2e-manual-qa-checklist.mdpackages/dev-config/.eslintrc.base.js
💤 Files with no reviewable changes (11)
- .gitignore
- apps/provider-console/package.json
- .npmrc
- apps/deploy-web/package.json
- apps/deploy-web/src/styles/index.css
- apps/deploy-web/src/pages/get-started/index.tsx
- apps/provider-console/src/styles/index.css
- apps/deploy-web/src/types/global.ts
- apps/deploy-web/src/services/analytics/analytics.service.ts
- apps/provider-console/src/pages/get-started/index.tsx
- apps/deploy-web/src/components/liquidity-modal/index.tsx
Add unit tests for the GetStartedStepper component covering the balance display logic for both custodial and managed wallets. Introduce the DEPENDENCIES pattern to enable DI-based testing.
Address CodeRabbit review: include MetaMask in the QA checklist since it's still a supported wallet option in deploy-web.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/deploy-web/src/components/get-started/GetStartedStepper.spec.tsx`:
- Around line 57-63: The balance mock is only created when input.balanceUAKT
exists, which skips creating a balance object if only balanceUUSDC or
balanceUACT are provided; update the gating in the GetStartedStepper.spec.tsx
test to create the balance object when any of input.balanceUAKT,
input.balanceUUSDC, or input.balanceUACT is defined (e.g., check
input?.balanceUAKT !== undefined || input?.balanceUUSDC !== undefined ||
input?.balanceUACT !== undefined) and still fill the properties using the
existing fallback logic (balanceUUSDC: input?.balanceUUSDC ?? 0, balanceUACT:
input?.balanceUACT ?? 0).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 73bfd44b-e2ee-4e38-b51d-dfb05d35cc99
📒 Files selected for processing (3)
apps/deploy-web/src/components/get-started/GetStartedStepper.spec.tsxapps/deploy-web/src/components/get-started/GetStartedStepper.tsxdoc/e2e-manual-qa-checklist.md
🚧 Files skipped from review as they are similar to previous changes (2)
- doc/e2e-manual-qa-checklist.md
- apps/deploy-web/src/components/get-started/GetStartedStepper.tsx
Address CodeRabbit review: balance mock now activates when any of balanceUAKT, balanceUUSDC, or balanceUACT is provided, not just balanceUAKT.
Contributor
|
should we wait till May 28, 2026? |
Contributor
Author
Sure we can, I don't think it matters. |
ygrishajev
reviewed
Apr 16, 2026
| import { MockComponents } from "@tests/unit/mocks"; | ||
|
|
||
| describe(GetStartedStepper.name, () => { | ||
| it("displays AKT and USDC balance for custodial wallet", () => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes CON-182
Leap is sunsetting their wallet extension. This PR removes all Leap wallet integration from the codebase.
What
@cosmos-kit/leapand@cosmos-kit/leap-extensiondependencies from deploy-web and provider-console@leapwallet/elementsliquidity modal (swap/bridge/fiat on-ramp) and its CSSCustomChainProviderLeapElementsglobal type declarationleap_get_more_tokens,leap_tx_complete)@leapwallet/elementsscript/stylesheet tags from get-started pagesinitLeapWebWalletMock→initKeplrWebWalletMock)connectWalletViaLeap→connectWalletViaKeplrin test fixtures.npmrc(removed@leapwalletregistry),.gitignore, and ESLint configSummary by CodeRabbit