refactor(onboarding): infer step from user state instead of localStorage#3084
Open
baktun14 wants to merge 1 commit intofeat/auth0-verification-frontendfrom
Open
refactor(onboarding): infer step from user state instead of localStorage#3084baktun14 wants to merge 1 commit intofeat/auth0-verification-frontendfrom
baktun14 wants to merge 1 commit intofeat/auth0-verification-frontendfrom
Conversation
Remove localStorage-based onboarding step persistence and derive the current step from actual user data (userId, emailVerified, hasManagedWallet). This eliminates bugs caused by stale or inconsistent stored state.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Remove localStorage-based onboarding step persistence in favor of deriving the current step from actual user data (
userId,emailVerified,hasManagedWallet). Stored state could go stale or diverge from reality, causing the stepper to land on the wrong step.Stacked on #3052. Retarget to
mainonce that merges.What
inferStep(user, hasManagedWallet)+deriveCompletedSteps(step)helpers inOnboardingContaineruseStatefor current/completed steps withuseMemoderivationlocalStoragereads/writes fromOnboardingContainer,VerifyEmailPage, andAuthService.logout()@src/services/storage/keys.ts(no longer referenced)isLoadingto onboarding children props;OnboardingViewrenders a spinner placeholder while data resolvesuseUser/usePaymentMethodsQuerywith proper{data, isLoading}shape, add coverage for each inferred-step branch