Merged
Conversation
stalniy
force-pushed
the
refactor/extract-price-updater
branch
from
25d20a0 to
00752e9
Compare
stalniy
force-pushed
the
refactor/extract-price-updater
branch
from
00752e9 to
9f746d9
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the price-feeding logic out of HermesClient into a dedicated “price updater” abstraction, with the intent to allow alternative update strategies.
Changes:
- Introduces
PriceUpdater/PriceUpdateOptions/UpdatePriceFeedMsgtypes insrc/types.ts. - Adds
PriceUpdateConfirmedimplementation that executes the on-chain contract update. - Updates
HermesClient.updatePrice()to delegate execution toPriceUpdateConfirmed(via a cached#priceUpdater), and adds unit tests for the new updater.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/types.ts | Adds updater-related interfaces and moves UpdatePriceFeedMsg type here. |
| src/price-update/price-update-confirmed/price-update-confirmed.ts | New extracted updater that submits VAAs via SigningCosmWasmClient.execute. |
| src/price-update/price-update-confirmed/price-update-confirmed.test.ts | Unit tests validating message/funds, return shape, and error propagation. |
| src/hermes-client.ts | Refactors price update execution to use PriceUpdater and removes the locally-defined UpdatePriceFeedMsg + adjusts exports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…firmed.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Serhii Stotskyi <sergiy.stotskiy@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Serhii Stotskyi <sergiy.stotskiy@gmail.com>
baktun14
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
To have a possibility to provide a different implementation of price updater (e.g., fire and forget)
What
extracts price feeding from hermes client