Fix logger property render bug - #255
Merged
Merged
Conversation
Aaronontheweb
requested changes
Aug 30, 2023
Aaronontheweb
left a comment
Aaronontheweb
left a comment
Member
There was a problem hiding this comment.
Looks good, as far as I know - but can we get some snapshot tests with Verify on Akka.NET v1.4 (separate PR) and then bring it into dev ? That way we know if we're moving someone else's cheese around with this change.
Contributor
Author
| /// </returns> | ||
| public string Format(string format, params object[] args) | ||
| { | ||
| if (Log.Logger.BindMessageTemplate(format, args, out var boundTemplate, out var boundProps)) |
Member
There was a problem hiding this comment.
Please add a comment explaining what this does and how the fallback mechanism works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes