De-flake ShardedDaemonProcessSpec multinode spec (#8431) - #8492
Merged
Conversation
Backport of dev commit dcd9acb to v1.5, scoped to the ShardedDaemonProcessSpec rewrite. The Player.cs / MultiNodeTestRunner.cs portions of akkadotnet#8431 were already delivered to v1.5 in the MNTR conductor reliability backport (akkadotnet#8488), so only the spec change is taken here. Rewrite the ShardedDaemonProcess multinode spec to be async and resistant to slow-CI barrier timeouts: - task-returning TestKit methods throughout (no sync-over-async) - single cluster-wide collector probe on 'first' so shards reallocated during cluster settle are reported correctly - fish for a complete distinct-ID set instead of assuming 4 messages - raise testconductor barrier-timeout to 60s for slow agents - fix HOCON brace nesting that dropped keep-alive-interval Adapted to v1.5: AwaitClusterUpAsync(CancellationToken.None, ...) to match the v1.5 TestKit signature. (cherry picked from commit dcd9acb)
Aaronontheweb
enabled auto-merge (squash)
August 27, 2026 02:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8431's ShardedDaemonProcessSpec rewrite to v1.5, scoped to the spec change only. The Player.cs / MultiNodeTestRunner.cs portions of #8431 were already delivered to v1.5 in the MNTR conductor reliability backport (#8488), so only the spec is picked here.
Cherry-picked from dev commit
dcd9acb14with attribution (see commit trailer).Changes
AwaitClusterUpAsync,EnterBarrierAsync,FishForMessageAsync) - no sync-over-asyncfirstso shards reallocated while the cluster settles are reported correctlyakka.testconductor.barrier-timeoutto 60s for slow CI agentskeep-alive-intervalAdapted to v1.5:
AwaitClusterUpAsync(CancellationToken.None, ...)to match the v1.5 TestKit signature.Validation