Skip to content

Fix disk usage reporting by improving partition selection logic #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brianmatzelle wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix disk usage reporting by improving partition selection logic #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion lib/monitor/disk.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,24 @@ function Disk(donut) {
}

Disk.prototype.updateData = function(data) {
var disk = data[0];
var disk;

// Filter out very small filesystems (< 100MB) to avoid system partitions
var relevantFilesystems = data.filter(fs => fs.size > 100 * 1024 * 1024);

if (process.platform === 'darwin') {
// macOS: prefer /System/Volumes/Data or root, or largest
disk = relevantFilesystems.find(fs => fs.mount === '/System/Volumes/Data') ||
relevantFilesystems.find(fs => fs.mount === '/') ||
relevantFilesystems.reduce((prev, curr) => prev.size > curr.size ? prev : curr, relevantFilesystems[0]);
} else {
// Linux/Unix: find root filesystem or largest
disk = relevantFilesystems.find(fs => fs.mount === '/') ||
relevantFilesystems.reduce((prev, curr) => prev.size > curr.size ? prev : curr, relevantFilesystems[0]);
}

// Fallback to first filesystem if nothing found
disk = disk || data[0];

var label =
utils.humanFileSize(disk.used, true) +
Expand Down