Skip to content

fix: add missing promotiontask permissions to project admin role#6335

Merged
krancour merged 1 commit into
akuity:mainfrom
badstreff:fix/project-rbac
May 28, 2026
Merged

fix: add missing promotiontask permissions to project admin role#6335
krancour merged 1 commit into
akuity:mainfrom
badstreff:fix/project-rbac

Conversation

@badstreff

@badstreff badstreff commented May 22, 2026

Copy link
Copy Markdown
Contributor

All pull requests must reference an existing issue with no blocking labels.
PRs that do not meet this requirement will be automatically closed. See the
Contributor Guide for details.

Issue Reference

N/A

Description

Add missing PromotionTask permissions to the project admin role

Checklist

  • The PR is linked to an existing issue.
  • The linked issue has no blocking labels (kind/proposal,
    needs discussion, needs research, maintainer only, area/security,
    size/large, size/x-large, size/xx-large).
  • I have added or updated tests as appropriate.
  • I have added or updated documentation as appropriate.

AI Use Disclosure

Select one:

  • This PR was written by a human without AI assistance.
  • This PR was written by a human with AI assistance. A human has reviewed every line prior to opening the PR.
  • This PR was written by an AI with human supervision. A human has reviewed every line prior to opening the PR.
  • This PR was written entirely by AI. No human has reviewed this prior to opening the PR.

Sign-Off

  • All commits are signed off (git commit -s) (required)
  • All commits are cryptographically signed (git commit -S) (encouraged)

Signed-off-by: Adam Furbee <adam.furbee@gmail.com>
@badstreff badstreff requested a review from a team as a code owner May 22, 2026 16:40
@netlify

netlify Bot commented May 22, 2026

Copy link
Copy Markdown

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit f7827c6
🔍 Latest deploy log https://app.netlify.com/projects/docs-kargo-io/deploys/6a1086ee5f510e0008cba836
😎 Deploy Preview https://deploy-preview-6335.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kargo-governance-bot kargo-governance-bot Bot added needs/area Issue or PR needs to be labeled to indicate what parts of the code base are affected needs/kind Issue or PR needs to be labeled to clarify its nature needs/priority Priority has not yet been determined; a good signal that maintainers aren't fully committed labels May 22, 2026
@badstreff badstreff changed the title add missing promotiontask permissions to project admin role fix: add missing promotiontask permissions to project admin role May 22, 2026
@krancour

Copy link
Copy Markdown
Member

Nice find. Nice fix. Thank you.

@krancour krancour added kind/bug Something isn't working as intended; If unsure that something IS a bug, start a discussion instead priority/normal This is the priority for most work area/management-controller Affects the controller that manages the Kargo control plane itself area/security Has security implications and needs to be handled with great caution and removed needs/kind Issue or PR needs to be labeled to clarify its nature needs/priority Priority has not yet been determined; a good signal that maintainers aren't fully committed needs/area Issue or PR needs to be labeled to indicate what parts of the code base are affected labels May 28, 2026
@krancour krancour added this to the v1.10.5 milestone May 28, 2026
@krancour krancour enabled auto-merge May 28, 2026 18:40
@codecov

codecov Bot commented May 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.10%. Comparing base (3841bd2) to head (f7827c6).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6335   +/-   ##
=======================================
  Coverage   58.10%   58.10%           
=======================================
  Files         499      499           
  Lines       41807    41807           
=======================================
  Hits        24292    24292           
  Misses      16054    16054           
  Partials     1461     1461           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@krancour krancour added this pull request to the merge queue May 28, 2026
Merged via the queue into akuity:main with commit b7d653e May 28, 2026
25 of 28 checks passed
@akuitybot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/management-controller Affects the controller that manages the Kargo control plane itself area/security Has security implications and needs to be handled with great caution backport/release-1.10 kind/bug Something isn't working as intended; If unsure that something IS a bug, start a discussion instead priority/normal This is the priority for most work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants