fix: the parameter of deploy in Counter.ts#39
Open
yoyoj1023 wants to merge 1 commit intoalchemyplatform:mainfrom
Open
fix: the parameter of deploy in Counter.ts#39yoyoj1023 wants to merge 1 commit intoalchemyplatform:mainfrom
yoyoj1023 wants to merge 1 commit intoalchemyplatform:mainfrom
Conversation
fix: the parameter of deploy in Counter.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: add missing constructor parameter to Counter contract deployment
Description
Fixed the missing constructor parameter issue when deploying the Counter contract in
packages/hardhat/test/Counter.ts.Problem:
The original test code was deploying the Counter contract without providing the required constructor parameter:
Solution:
After examining the
Counter.solcontract's constructor, it requires auint _xparameter to initialize the state variablex:Therefore, added the initial value parameter
10in the test deployment:This fix ensures that the test can execute properly and the contract is deployed with an appropriate initial value.
Additional Information
Related Issues
Note: This is a small and straightforward bug fix that resolves a deployment parameter mismatch between the contract constructor and test deployment call.
Your ENS/address:
0xdb4101e7f5E2cC0e1A749092ff5287e3d36A5df6