Conversation
|
Do the changes also apply to e.g. the Unicode Character 'RIGHT SINGLE QUOTATION MARK' (U+2019)? |
Owner
Author
|
Nope not yet. And that's egg on my face because that's what the original issue was about! Here is a slightly more advanced test case that covers U+2019 as well: SILE test code
Full test output: quote.pdf Clearly not addressed yet... |
Owner
Author
Owner
Author
|
Yes. Actually all the other weights and styles need adjusting, but I was putting it off since I'm not ready to merge this (which will be a major breaking change). I'll do it eventually and probably keep it along with some other big changes in a devel branch for a while before enough comes together to do a breaking release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #323.
This currently a WIP, but when it does land it will be a significant change to metrics, so I will probably delay merging this until after a few small fixes hit and a minor dot release happens first.
test code
@rriemann What do you think of this? (Besides the preview above you can download artifacts from the Actions tab of this PR to test for yourself.)