Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Mermaid diagrams illustrating event workflow and supervisor internals #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Add Mermaid diagrams illustrating event workflow and supervisor internals #1
Changes from all commits
6f246b3File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Align the state machine with the actual descriptor lifecycle.
Debounce -> [*]incorrectly makesOneShotterminal; the implementation only disarms the timer, so a latertrigger()can begin another cycle. The diagram also omits theInterval, delay == 0transition fromDebounceto immediate send/Heartbeat.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Route external triggers through
EventSupervisor.The actual API is
EventSupervisor::trigger(EventId, EventValue), which finds the descriptor before invokingEventDescriptor::trigger(). ShowingExt->>Descbypasses that routing and contradicts the component diagram; add a supervisor participant to the sequence.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
Do not describe the lifecycle guard as production enforcement.
assert()is disabled in release builds. A post-start()registration can therefore mutate the descriptor vector while the worker iterates it, so this is a precondition/debug check rather than an enforced runtime guarantee. Clarify the wording or add a release-mode guard in the implementation.🤖 Prompt for AI Agents