Skip to content

(fix): set max_env_num_per_worker to 1 in webshop. #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PanAndy merged 1 commit into from
Aug 4, 2025
Merged

(fix): set max_env_num_per_worker to 1 in webshop. #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/qwen2.5-7B-agentic_megatron/agentic_val_webshop.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,14 @@ train_env_manager:
format_penalty: -0.05
num_env_groups: 8
group_size: 8
max_env_num_per_worker: 4
max_env_num_per_worker: 1 # The max_env_num_per_worker must be set to 1 to avoid conflicts with the webshop simple server.
tags: [WebShopEnv]
num_groups_partition: [8] # If not set, all env names divide nums equally. Under the same group, the env config and env seed (prompt) are equal in each generation

val_env_manager:
num_env_groups: 64
group_size: 1 # should be set to 1 because val temperature is set to 0 and same prompt leads to same output
max_env_num_per_worker: 4
max_env_num_per_worker: 1 # The max_env_num_per_worker must be set to 1 to avoid conflicts with the webshop simple server.
tags: [WebShopEnv]
num_groups_partition: [64] # TODO: If not set, all env names divide nums equally. Under the same group, the env config and env seed (prompt) are equal in each generation

Expand Down
4 changes: 2 additions & 2 deletions examples/qwen2.5-7B-agentic_megatron/agentic_val_webshop_async.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,14 +144,14 @@ train_env_manager:
format_penalty: -0.05
num_env_groups: 8
group_size: 8
max_env_num_per_worker: 4
max_env_num_per_worker: 1 # The max_env_num_per_worker must be set to 1 to avoid conflicts with the webshop simple server.
tags: [WebShopEnv]
num_groups_partition: [8] # If not set, all env names divide nums equally. Under the same group, the env config and env seed (prompt) are equal in each generation

val_env_manager:
num_env_groups: 64
group_size: 1 # should be set to 1 because val temperature is set to 0 and same prompt leads to same output
max_env_num_per_worker: 4
max_env_num_per_worker: 1 # The max_env_num_per_worker must be set to 1 to avoid conflicts with the webshop simple server.
tags: [WebShopEnv]
num_groups_partition: [64] # TODO: If not set, all env names divide nums equally. Under the same group, the env config and env seed (prompt) are equal in each generation

Expand Down