fix(sec-core): expose skill ledger verdicts#1577
Open
1570005763 wants to merge 1 commit into
Open
Conversation
Project command-specific Skill Ledger states into a canonical event verdict. Keep CLI response contracts unchanged. Expose verdict, command, and skill name on dashboard rows. Historical records and telemetry remain unchanged. Assisted-by: Codex Signed-off-by: 1570005763 <daniel.duan@linux.alibaba.com>
1570005763
force-pushed
the
codex/skill-ledger-dashboard-events
branch
from
July 20, 2026 07:50
76407a1 to
e4a8e05
Compare
1570005763
marked this pull request as ready for review
July 20, 2026 08:09
1570005763
requested review from
RemindD,
chengshuyi,
edonyzpc,
jfeng18 and
kid9
as code owners
July 20, 2026 08:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Skill Ledger
showevents currently keep verdicts only under the latest and activeobjects, so SQLite cannot index one canonical verdict and Dashboard rows without
details cannot display key fields. This change projects command-specific Skill Ledger
states into
details.result.verdictwithout changing CLI results, then exposes optionalverdict,command, andskill_namefields on Dashboard API rows. Dashboard consumersprefer those top-level fields when details are omitted and classify
tamperedas riskand
driftedas warning. Batchinit,scan, andcheckcommands use the most severechild result, while historical records, SQLite schema, and telemetry remain unchanged.
Related Issue
no-issue: internal security observability compatibility requirement has no public GitHub issue
Type of Change
Scope
cosh(copilot-shell)cosh-ng(cosh-ng)sec-core(agent-sec-core)skill(os-skills)sight(agentsight)tokenless(tokenless)ckpt(ws-ckpt)memory(agent-memory)anolisa(anolisa-cli)skillfs(SkillFS)Checklist
cosh: Lint passes, type check passes, and tests passcosh-ng:cargo clippy --all-targets -- -D warningsandcargo fmt --checkpasssec-core(Rust):cargo clippy -- -D warningsandcargo fmt --checkpasssec-core(Python): Ruff format and pytest passskill: Skill directory structure is valid and shell scripts pass syntax checksight:cargo clippy -- -D warningsandcargo fmt --checkpasstokenless:cargo clippy -- -D warningsandcargo fmt --checkpassmemory(Linux only):cargo clippy --all-targets -- -D warnings,cargo fmt --check, andcargo testpassanolisa:cargo clippy --all-targets --locked -- -D warnings,cargo fmt --all --check, andcargo test --lockedpassskillfs:cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warnings, andcargo test --workspacepasspackage-lock.json/Cargo.lock)Testing
Result: 442 backend tests and 14 targeted Dashboard tests passed. Dashboard typecheck
and the production embed build also passed.
Additional Notes
status,audit,export,list-scanners, andinit-keysintentionally do notproject a canonical verdict;
status --verbosepreserves child statuses only.AgentHealthSidebar,App, andTokenSavingsPage; the identical failures reproduce onupstream/main.