Skip to content

helm: fix nil pointer evaluating#3533

Open
cyclinder wants to merge 1 commit intoalibaba:mainfrom
cyclinder:fix_chart
Open

helm: fix nil pointer evaluating#3533
cyclinder wants to merge 1 commit intoalibaba:mainfrom
cyclinder:fix_chart

Conversation

@cyclinder
Copy link
Copy Markdown

Ⅰ. Describe what this PR did

helm template higress helm/core   
Error: template: higress-core/templates/deployment.yaml:45:6: executing "higress-core/templates/deployment.yaml" at <include "gateway.podTemplate" $>: error calling include: template: higress-core/templates/_pod.tpl:128:15: executing "gateway.podTemplate" at <include "skywalking.enabled" .>: error calling include: template: higress-core/templates/_helpers.tpl:100:106: executing "skywalking.enabled" at <.Values.tracing.skywalking.service>: nil pointer evaluating interface {}.service

Use --debug flag to render out invalid YAML

Ⅱ. Does this pull request fix one issue?

fixes #3532

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

helm template higress helm/core
---
# Source: higress-core/templates/controller-serviceaccont.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
  name: higress-controller
  namespace: default
  labels:
    helm.sh/chart: higress-core-2.2.0
    app: higress-controller
    higress: higress-controller
    app.kubernetes.io/version: "2.2.0"
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: higress-controller
...

Ⅴ. Special notes for reviews

Ⅵ. AI Coding Tool Usage Checklist (if applicable)

Please check all applicable items:

  • For new standalone features (e.g., new wasm plugin or golang-filter plugin):

    • I have created a design/ directory in the plugin folder
    • I have added the design document to the design/ directory
    • I have included the AI Coding summary below
  • For regular updates/changes (not new plugins):

    • I have provided the prompts/instructions I gave to the AI Coding tool below
    • I have included the AI Coding summary below

AI Coding Prompts (for regular updates)

AI Coding Summary

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

helm chart template issue

2 participants