fix(graph): prevent duplicated append results when merging serial subgraphs#4527
Open
gaozexun wants to merge 2 commits intoalibaba:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
This PR fixes duplicated/over-amplified
AppendStrategyresults when parent graph merges serial subgraph outputs (Issue #4515).Before the fix, serial subgraph executions could produce duplicated
outputvalues:Does this pull request fix one issue?
Closes #4515
Describe how you did it
Two changes were applied:
SubCompiledGraphNodeAction, once subgraph saver exists, always assign deterministic node-scoped threadId:${parentThreadId}_${subGraphId(nodeId)}orsubGraphId(nodeId)OverAllState.withResetKeys(Set<String>).SubCompiledGraphNodeAction, build subgraph initial state by removing all keys whose strategy isAppendStrategy.Also added a non-mock reproduction test class:
Issue4515ReproductionTest(3 scenarios)Describe how to verify it
Run: