fix(graph): avoid mutating append inputs#4780
Open
Gujiassh wants to merge 1 commit into
Open
Conversation
3e59352 to
46be2ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
This keeps
AppendStrategy.apply(oldValue, newValue)side-effect free whenoldValueis already aListandnewValueis a single non-collection value.Today that branch appends directly into the incoming
oldListand returns the same instance. Any caller that still holds the original list reference can observe the mutation, which leaks state across history snapshots and checkpointed branches.Does this pull request fix one issue?
Fixes #4757
Describe how you did it
oldListinto a newArrayListoldListstays unchanged while the returned list contains the appended valueDescribe how to verify it
./mvnw -pl spring-ai-alibaba-graph-core -Dtest=AppendStrategyMutationRegressionTest testgit diff --checkSpecial notes for reviews
This is intentionally scoped to the single-value append path only. Existing list/list merge behavior and remove-identifier handling are left unchanged.