fix(agent): honor returnDirect routing#4786
Open
6mmLIU wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 25af7143e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the ReactAgent
returnDirectrouting behavior reported in #4427.jump_tois a transient hook routing command, but it was stored in graph state. After a returnDirect tool setjump_to=end, the checkpoint for that turn could carry the stale command into a later invocation on the same thread and short-circuit before the model ran. ReactAgent also did not install the existing return-direct model hook by default, so@Tool(returnDirect = true)was not honored unless users wired the hook manually.This change:
ReturnDirectModelHookautomatically for tool-enabled ReactAgent instances unless an equivalent hook is already presentjump_towhen routing so one-shot hook decisions do not leak through checkpoints or later turnsReturnDirectModelHookend direct tool responses while normal tools still return to the modelChatModelregression test covering direct tools, same-thread follow-up turns, and normal tool routingFixes #4427
Tests
./mvnw -pl :spring-ai-alibaba-agent-framework -am -Dtest=ReactAgentReturnDirectRoutingTest test