fix:#4020 The log was incorrectly printed: "A cross-cluster call occurs"#4021
Open
HDHXTM wants to merge 1 commit intoalibaba:2021.xfrom
Open
fix:#4020 The log was incorrectly printed: "A cross-cluster call occurs"#4021HDHXTM wants to merge 1 commit intoalibaba:2021.xfrom
HDHXTM wants to merge 1 commit intoalibaba:2021.xfrom
Conversation
|
|
|
I encountered the same issue. Why has no one taken ownership of this issue, and why has this PR not been reviewed or approved? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Due to this pull request（https://github.com/alibaba/spring-cloud-alibaba/pull/3771）, the default value for com.alibaba.cloud.nacos.NacosDiscoveryProperties#clusterName was removed. When the user does not explicitly specify a clusterName, the method com.alibaba.cloud.nacos.loadbalancer.NacosLoadBalancer#getInstanceResponse will directly enter the else block, causing the message "A cross-cluster call occurs" to be logged incorrectly.
Does this pull request fix one issue?
Fixes #4020
Describe how you did it
Describe how to verify it
Special notes for reviews