Optimize ibverbs: batch CQ polling, eliminate heap allocation, fix branch hints, and correct gid_to_string off-by-one.#1162
Merged
poor-circle merged 2 commits intoalibaba:mainfrom Apr 3, 2026
Conversation
ib_device.hpp: ibv_reg_mr success path was incorrectly marked [[unlikely]], causing CPU branch predictor to optimize for the failure path. Changed to [[likely]] since registration normally succeeds. Signed-off-by: zhaoshang <zhaoshangsjtu@linux.alibaba.com>
|
|
The GID format "%02x%02x:..." produces exactly 39 characters, but the string was resize(40), leaving an embedded '\0' at position 39. This caused the returned std::string to carry a trailing null byte, which could lead to subtle comparison or display issues downstream (e.g. when used with asio::ip::make_address). Also replaced sprintf with snprintf for buffer safety, explicitly passing the buffer size (39 chars + null terminator = 40 bytes). Signed-off-by: zhaoshang <zhaoshangsjtu@linux.alibaba.com>
|
for detail, goto summary download Artifacts |
Collaborator
|
@power-more 记得签下CLA |
Contributor
Author
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
What is changing
Example